From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [RFC v14-rc2][PATCH 19/29] Record 'struct file' object instead of the file name for VMAs Date: Wed, 1 Apr 2009 16:45:09 -0500 Message-ID: <20090401214509.GA27725@us.ibm.com> References: <1238477349-11029-1-git-send-email-orenl@cs.columbia.edu> <1238477349-11029-20-git-send-email-orenl@cs.columbia.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1238477349-11029-20-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oren Laadan Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Dave Hansen List-Id: containers.vger.kernel.org Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org): > The vma->vm_file can be an arbitrary file pointer, including one that > is in use by a process as well and provided originally via the mmap() > syscall. > > Thus, when dumping the state of a VMA, save a file object instead > of only the file name. As with other file objects, if it's seen for > the first time it is dumped entirely, otherwise only the 'objref' is > saved. The restart logic updated accordingly. > > Changelog[v14]: > - Introduce patch > > Signed-off-by: Oren Laadan Acked-by: Serge Hallyn (I assume this was on your todo list before Alexey pointed it out? If not, it might be gracious to mention him) -serge