Re: [PATCH] gcc-cross-kernel-3.3.4

["Jörg Bakker" <joerg@hakker.de>]

[-- Attachment #1: Type: text/plain, Size: 2593 bytes --]

Yes, you're right. Changed patch is attached.

Thanks for the hint.

Am Dienstag 31 März 2009 23:41:03 schrieb Khem Raj:
> Thanks for the patch something like S_IRUSR | S_IWUSR instead of 0666
> would be better.
>
> On 3/30/09, Jörg Bakker <joerg@hakker.de> wrote:
> > Building gcc-cross-kernel-3.3.4 stops with the following error:
> > | In function 'open',
> > |
> > |     inlined from 'collect_execute' at
> >
> > /home/jb/devel/cc/jammsession/oe/build/tmp/work/i586-angstrom-linux/gcc-c
> >ross-
> >
> > kernel-3.3.4-3.3.4-r9/gcc-3.3.4/gcc/collect2.c:1575:
> > | /usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode'
> >
> > declared
> > with attribute error: open with O_CREAT in second argument needs 3
> > arguments
> >
> > | make[1]: *** [collect2.o] Error 1
> > |
> > | make[1]: *** Waiting for unfinished jobs....
> > |
> > | done
> >
> > ....
> >
> > | make[1]: Leaving directory
> >
> > `/home/jb/devel/cc/jammsession/oe/build/tmp/work/i586-angstrom-linux/gcc-
> > cross-kernel-3.3.4-3.3.4-r9/gcc-3.3.4/build.i686-linux.i586-angstrom-
> > linux/gcc'
> >
> > | make: *** [all-gcc] Error 2
> > | FATAL: oe_runmake failed
> >
> > NOTE: Task failed: /home/jb/devel/cc/jammsession/oe/build/tmp/work/i586-
> > angstrom-linux/gcc-cross-kernel-3.3.4-3.3.4-r9/temp/log.do_compile.17555
> > NOTE: package gcc-cross-kernel-3.3.4-3.3.4-r9: task do_compile: failed
> > ERROR: TaskFailed event exception, aborting
> > ERROR: Build of
> > /home/jb/devel/cc/jammsession/oe/build/recipes/gcc.save/gcc-
> > cross-kernel-3.3.4_3.3.4.bb do_compile failed
> > ERROR: Task 7
> > (/home/jb/devel/cc/jammsession/oe/build/recipes/gcc.save/gcc-
> > cross-kernel-3.3.4_3.3.4.bb, do_compile) failed
> > NOTE: Tasks Summary: Attempted 271 tasks of which 265 didn't need to be
> > rerun
> > and 1 failed.
> > ERROR:
> > '/home/jb/devel/cc/jammsession/oe/build/recipes/gcc.save/gcc-cross-
> > kernel-3.3.4_3.3.4.bb' failed
> >
> > OE Build Configuration:
> > BB_VERSION        = "1.8.13"
> > METADATA_BRANCH   = "org.openembedded.dev"
> > METADATA_REVISION = "8f8efbe43a7f28802d066f7f83915e8fbd0d4cc2"
> > TARGET_ARCH       = "i586"
> > TARGET_OS         = "linux"
> > MACHINE           = "epia"
> > DISTRO            = "angstrom"
> > DISTRO_VERSION    = "2009.X-test-20090329"
> >
> > The attached patch fixes this.
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel


[-- Attachment #2: gcc-cross-kernel-334.patch --]
[-- Type: text/x-patch, Size: 1382 bytes --]

diff -Nur openembedded/recipes/gcc/gcc-cross-kernel-3.3.4/gcc334-collect2_file_open_args.patch build/recipes/gcc/gcc-cross-kernel-3.3.4/gcc334-collect2_file_open_args.patch
--- openembedded/recipes/gcc/gcc-cross-kernel-3.3.4/gcc334-collect2_file_open_args.patch	1970-01-01 01:00:00.000000000 +0100
+++ build/recipes/gcc/gcc-cross-kernel-3.3.4/gcc334-collect2_file_open_args.patch	2009-03-21 17:34:07.000000000 +0100
@@ -0,0 +1,11 @@
+--- gcc-3.3.4/gcc/collect2.c.orig	2009-03-21 17:26:11.000000000 +0100
++++ gcc-3.3.4/gcc/collect2.c	2009-03-21 17:26:47.000000000 +0100
+@@ -1572,7 +1572,7 @@
+   if (redir)
+     {
+       /* Open response file.  */
+-      redir_handle = open (redir, O_WRONLY | O_TRUNC | O_CREAT);
++      redir_handle = open (redir, O_WRONLY | O_TRUNC | O_CREAT, S_IRUSR | S_IWUSR);
+ 
+       /* Duplicate the stdout and stderr file handles
+ 	 so they can be restored later.  */
diff -Nur openembedded/recipes/gcc/gcc-cross-kernel-3.3.4_3.3.4.bb build/recipes/gcc/gcc-cross-kernel-3.3.4_3.3.4.bb
--- openembedded/recipes/gcc/gcc-cross-kernel-3.3.4_3.3.4.bb	2009-03-21 10:44:02.000000000 +0100
+++ build/recipes/gcc/gcc-cross-kernel-3.3.4_3.3.4.bb	2009-03-21 17:39:11.000000000 +0100
@@ -1,2 +1,3 @@
 require gcc-cross-initial_${PV}.bb
 require gcc-cross-kernel.inc
+SRC_URI_append = "file://gcc334-collect2_file_open_args.patch;patch=1"