All of lore.kernel.org
 help / color / mirror / Atom feed
From: mbroz@sourceware.org <mbroz@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/tools lvmcmdline.c
Date: 2 Apr 2009 14:59:48 -0000	[thread overview]
Message-ID: <20090402145948.23571.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mbroz at sourceware.org	2009-04-02 14:59:48

Modified files:
	tools          : lvmcmdline.c 

Log message:
	Do not use pointer from released memory pool (cmd->cmd_line).

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvmcmdline.c.diff?cvsroot=lvm2&r1=1.94&r2=1.95

--- LVM2/tools/lvmcmdline.c	2009/02/22 22:11:59	1.94
+++ LVM2/tools/lvmcmdline.c	2009/04/02 14:59:48	1.95
@@ -1026,16 +1026,16 @@
 	cmd->current_settings = cmd->default_settings;
 	_apply_settings(cmd);
 
-	/*
-	 * free off any memory the command used.
-	 */
-	dm_pool_empty(cmd->mem);
-
 	if (ret == EINVALID_CMD_LINE && !_cmdline.interactive)
 		_short_usage(cmd->command->name);
 
 	log_debug("Completed: %s", cmd->cmd_line);
 
+	/*
+	 * free off any memory the command used.
+	 */
+	dm_pool_empty(cmd->mem);
+
 	return ret;
 }
 



             reply	other threads:[~2009-04-02 14:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02 14:59 mbroz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-11 12:49 LVM2/tools lvmcmdline.c agk
2012-03-01 21:17 zkabelac
2012-02-13 12:07 zkabelac
2011-08-04 14:54 zkabelac
2011-08-04 14:11 zkabelac
2011-04-22 12:07 prajnoha
2011-01-13 15:00 zkabelac
2010-12-20 13:59 zkabelac
2010-12-20 13:16 zkabelac
2010-11-29 11:14 zkabelac
2010-04-30 13:47 prajnoha
2010-04-30 13:28 prajnoha
2010-03-23 15:13 prajnoha
2010-01-21 13:41 zkabelac
2009-07-27 21:01 wysochanski
2009-07-07  1:51 wysochanski
2008-12-11  3:34 wysochanski
2008-12-11  3:31 wysochanski
2008-12-11  3:28 wysochanski
2008-11-18 10:13 zkabelac
2008-11-12  9:49 zkabelac
2008-09-19  7:11 agk
2007-09-21 18:43 meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090402145948.23571.qmail@sourceware.org \
    --to=mbroz@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.