From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 2/3] c/r: Add UTS support (v6) Date: Thu, 2 Apr 2009 13:09:36 -0500 Message-ID: <20090402180936.GE21178@us.ibm.com> References: <1238533107-11796-1-git-send-email-danms@us.ibm.com> <1238533107-11796-3-git-send-email-danms@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1238533107-11796-3-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dan Smith Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org List-Id: containers.vger.kernel.org Quoting Dan Smith (danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org): > + ret = cr_read_string(ctx, nn, hh.nodename_len); > + if (ret < 0) > + goto out; > + > + ret = cr_read_string(ctx, dn, hh.domainname_len); > + if (ret < 0) > + goto out; > + > + ret = sys_unshare(CLONE_NEWUTS); > + if (ret) > + goto out; > + > + ns = t->nsproxy->uts_ns; > + memcpy(ns->name.nodename, nn, hh.nodename_len); > + memcpy(ns->name.domainname, dn, hh.domainname_len); Actually, I think you must make sure the user didn't slip in a nodename_len which was > sizeof(ns->name.nodename). -serge