All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-ide@vger.kernel.org,
	Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ide: Fix host drivers that need IRQF_SHARED
Date: Thu, 2 Apr 2009 20:45:49 +0200	[thread overview]
Message-ID: <200904022045.54971.bzolnier@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0903312115050.29238@anakin>

On Tuesday 31 March 2009, Geert Uytterhoeven wrote:
> commit 255115fb35f80735c21a1cbe9809e9795a3af26e ("ide: allow host drivers to
> specify IRQ flags") added irq_flags fields to struct ide_port_info and struct
> ide_host.  Drivers can now set ide_port_info.irq_flags = IRQF_SHARED, while
> init_irq() passes ide_host.irq_flags to request_irq().
> 
> Unfortunately ide_host.irq_flags is never set, causing (on ARAnyM):
> 
> | Uniform Multi-Platform E-IDE driver
> | ide: Falcon IDE controller
> | Probing IDE interface ide0...
> | hda: Sarge m68k, ATA DISK drive
> | init_irq: sa = 0
> | ide0: disabled, unable to get IRQ 15
> | ide0: failed to initialize IDE interface
> | ide0: disabling port
> 
> Solve this by copying ide_port_info.irq_flags to ide_host.irq_flags in
> ide_host_alloc().
> 
> This bug probably affects the following IDE host drivers:
>   - buddha
>   - delkin_cb
>   - falconide
>   - gayle
>   - ide-cs
>   - macide
>   - q40ide
>   - scc_pata
>   - sgiioc4
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

applied

      reply	other threads:[~2009-04-02 19:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-31 19:16 [PATCH] ide: Fix host drivers that need IRQF_SHARED Geert Uytterhoeven
2009-04-02 18:45 ` Bartlomiej Zolnierkiewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904022045.54971.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.