From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [pnfs] [PATCH v2 06/47] nfsd41: Add Kconfig symbols for NFSv4.1 Date: Thu, 2 Apr 2009 18:49:20 -0400 Message-ID: <20090402224920.GG18195@fieldses.org> References: <20090402143141.GG24124@fieldses.org> <49D4E915.40705@panasas.com> <20090402165427.GA32533@fieldses.org> <49D4F9BE.3010102@panasas.com> <49D4FB68.20502@panasas.com> <20090402175517.GA5560@fieldses.org> <20090402175806.GB5560@fieldses.org> <49D506DD.8040705@panasas.com> <20090402184629.GF5560@fieldses.org> <49D50C91.7060707@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-nfs@vger.kernel.org, pnfs@linux-nfs.org, Trond Myklebust , Steve Dickson To: Benny Halevy Return-path: Received: from mail.fieldses.org ([141.211.133.115]:49483 "EHLO pickle.fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765227AbZDBWtW (ORCPT ); Thu, 2 Apr 2009 18:49:22 -0400 In-Reply-To: <49D50C91.7060707@panasas.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Apr 02, 2009 at 10:05:53PM +0300, Benny Halevy wrote: > On Apr. 02, 2009, 21:46 +0300, "J. Bruce Fields" wrote: > > On Thu, Apr 02, 2009 at 09:41:33PM +0300, Benny Halevy wrote: > >> It looks like rpc.nfsd's command line syntax is all negative. > >> I.e. all versions are on by default and they can be turned off > >> using the -N option. I can either add an option to enable minorversion > >> or have it enabled by default and add an option to disable it. > > > > I'm not a big fan of that commandline syntax--seems to me it should give > > a range rather than a list of versions not to support. > > > > For now the important thing is that the kernel default minorversion 1 to > > off. We can worry about what rpc.nfsd should do later--I guess a > > commandline option to turn on specific minor versions would work.... > > Maybe allow --nfs-version as well as --no-nfs-version? > > Sounds like a good idea. > How about --nfs-versions (in plural) to correspond to /proc/fs/nfsd/versions > and then pass the whole versions string? I suppose that would work, but it seems a little inconsistent with the current syntax, and with the way unix commandlines works in general. Something a little less idiosyncratic would be easier to document and remember. --b.