From: Ingo Molnar <mingo@elte.hu>
To: Joseph Cihula <joseph.cihula@intel.com>, Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, arjan@linux.intel.com
Subject: Re: [PATCH] x86: disable stack-protector for __restore_processor_state()
Date: Fri, 3 Apr 2009 19:30:59 +0200 [thread overview]
Message-ID: <20090403173059.GO19982@elte.hu> (raw)
In-Reply-To: <49D13385.5060900@intel.com>
* Joseph Cihula <joseph.cihula@intel.com> wrote:
> The __restore_processor_state() fn restores %gs on resume from S3.
> As such, it cannot be protected by the stack-protector guard since
> %gs will not be correct on function entry.
>
> There are only a few other fns in this file and it should not
> negatively impact kernel security that they will also have the
> stack-protector guard removed (and so it's not worth moving them
> to another file).
>
> Without this change, S3 resume on a kernel built with
> CONFIG_CC_STACKPROTECTOR_ALL=y will fail.
>
> Signed-off-by: Joseph Cihula <joseph.cihula@intel.com>
ah ... very nice!
applied to tip:x86/urgent, thanks Joseph!
Ingo
next prev parent reply other threads:[~2009-04-03 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 21:03 [PATCH] x86: disable stack-protector for __restore_processor_state() Joseph Cihula
2009-04-03 17:30 ` Ingo Molnar [this message]
2009-04-03 17:33 ` [tip:x86/urgent] " Joseph Cihula
2009-04-03 17:51 ` Joseph Cihula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090403173059.GO19982@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@linux.intel.com \
--cc=joseph.cihula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.