All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 5/5] mac80211: expose HT channel flags through debugfs
Date: Fri, 3 Apr 2009 11:12:59 -0700	[thread overview]
Message-ID: <20090403181259.GC10278@tesla> (raw)
In-Reply-To: <1238750659.27712.15.camel@johannes.local>

On Fri, Apr 03, 2009 at 02:24:19AM -0700, Johannes Berg wrote:
> On Thu, 2009-04-02 at 18:26 -0400, Luis R. Rodriguez wrote:
> 
> > +DEBUGFS_READONLY_FILE(ht40allowed, 20, "%d",
> > +		      !(local->hw.conf.channel->flags &
> > +		      IEEE80211_CHAN_NO_HT40));
> 
> Why don't you just expose
> ...FILE(flags, 20, "%#x", local->hw.conf.channel->flags))

I did first, I didn't like it. What I want is an easy to access
check for ht40- or ht40+. Not to have someone to cat the file and
do some bit map checks on it. This is debugfs afterall.

  Luis

      reply	other threads:[~2009-04-03 18:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02 22:26 [PATCH 0/5] wireless: listen to bandwidths preferences Luis R. Rodriguez
2009-04-02 22:26 ` [PATCH 1/5] cfg80211: Process regulatory max bandwidth checks for HT40 Luis R. Rodriguez
2009-04-03  9:22   ` Johannes Berg
2009-04-02 22:26 ` [PATCH 2/5] wireless: rename IEEE80211_CHAN_NO_FAT_* to HT40-/+ Luis R. Rodriguez
2009-04-03 15:01   ` Gábor Stefanik
2009-04-03 18:27     ` Luis R. Rodriguez
2009-04-03 18:28       ` Luis R. Rodriguez
2009-04-06 19:48         ` Luis R. Rodriguez
2009-04-02 22:26 ` [PATCH 3/5] mac80211: check if HT40+/- is allowed before sending assoc Luis R. Rodriguez
2009-04-03  9:22   ` Johannes Berg
2009-04-02 22:26 ` [PATCH 4/5] cfg80211: check allowed channel type upon userspace requests Luis R. Rodriguez
2009-04-03  9:23   ` Johannes Berg
2009-04-02 22:26 ` [PATCH 5/5] mac80211: expose HT channel flags through debugfs Luis R. Rodriguez
2009-04-03  9:24   ` Johannes Berg
2009-04-03 18:12     ` Luis R. Rodriguez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090403181259.GC10278@tesla \
    --to=lrodriguez@atheros.com \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.