From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LpoJs-0001GT-GN for mharc-grub-devel@gnu.org; Fri, 03 Apr 2009 14:40:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LpoJq-0001EM-1u for grub-devel@gnu.org; Fri, 03 Apr 2009 14:40:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LpoJp-0001D7-6R for grub-devel@gnu.org; Fri, 03 Apr 2009 14:40:45 -0400 Received: from [199.232.76.173] (port=50615 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LpoJo-0001Cw-W6 for grub-devel@gnu.org; Fri, 03 Apr 2009 14:40:45 -0400 Received: from mx20.gnu.org ([199.232.41.8]:2965) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LpoJo-0007iP-Il for grub-devel@gnu.org; Fri, 03 Apr 2009 14:40:44 -0400 Received: from mail.nexedi.com ([91.121.25.85] helo=nexedi.com) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LpoJl-0002KJ-Vv for grub-devel@gnu.org; Fri, 03 Apr 2009 14:40:42 -0400 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id B50AD3D9EF for ; Fri, 3 Apr 2009 20:40:36 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 4 Apr 2009 03:40:33 +0900 User-Agent: KMail/1.9.10 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904040340.33570.okuji@enbug.org> X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] Split of normal mode (version 2) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2009 18:40:46 -0000 On Tuesday 31 March 2009 02:41:14 Bean wrote: > Hi, > > This new patch make some changes based on the discussion of previous patch. > > 1, Move script engine to script/sh (sh.mod) > 2, Move generic menu code to menu (menu.mod) > 3, Move text menu viewer to menu/text (textmenu.mod) > 4, Move misc function to lib (misc.mod) > 5, Move setjmp to lib (setjmp.mod) I don't agree on the last two. Also, I don't like that you have just removed the rescue command. > Now normal.mod only contains the reader code. To configure script > engine and viewer, you should add these lines at the beginning of > grub.cfg: > > insmod sh > handler parser sh > insmod textmenu I prefer a more sophisticated approach (note: I hate manual loading). For example, we can allow a config file to have a shebang, like "#!sh". If not specified, GRUB can assume that "sh" is used, and load it automatically. This kind of technique could even allow for using different languages in one setup. For textmenu, I think it makes sense to have a command "textmenu". Just like "boot", GRUB can execute "textmenu" implicitly if a config file defines any menu entry but does not execute any menu command. This way, textmenu is automatically loaded. Regards, Okuji