From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: r2010
Date: Sat, 4 Apr 2009 05:16:10 +0900 [thread overview]
Message-ID: <200904040516.10598.okuji@enbug.org> (raw)
In-Reply-To: <ca0f59980904031256q5cb15912t5cf7ad49826a68f8@mail.gmail.com>
On Saturday 04 April 2009 04:56:14 Bean wrote:
> On Sat, Apr 4, 2009 at 3:43 AM, Yoshinori K. Okuji <okuji@enbug.org> wrote:
> > At r2010, Bean added fake_bios_data, and this function calls grub_printf.
> > Why not grub_dprintf? Was there any reason to print a message on the
> > screen?
>
> Hi,
>
> Well, I'm actually planning to move fake_bios_data to a separate
> module loadbios, so that linux loader would be cleaner.
I am afraid that you've got a disease of making more modules. This is a bad
disease. I have seen some projects which failed in refactoring due to this
disease (e.g. Zope3).
> The message is
> for debug purpose, it could be replaced with grub_dprintf.
OK.
Regards,
Okuji
next prev parent reply other threads:[~2009-04-03 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-03 19:43 r2010 Yoshinori K. Okuji
2009-04-03 19:56 ` r2010 Bean
2009-04-03 20:16 ` Yoshinori K. Okuji [this message]
2009-04-03 22:22 ` r2010 phcoder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904040516.10598.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.