From: David Brownell <david-b@pacbell.net>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix RTC-CMOS message, now with SOB
Date: Sat, 4 Apr 2009 11:02:07 -0700 [thread overview]
Message-ID: <200904041102.07751.david-b@pacbell.net> (raw)
In-Reply-To: <m3r60bvvrg.fsf@intrepid.localdomain>
On Thursday 02 April 2009, Krzysztof Halasa wrote:
> + !is_valid_irq(rtc_irq) ? "no alarms" :
> + cmos_rtc.mon_alrm ? "alarms up to one year" :
> + cmos_rtc.day_alrm ? "alarms up to one month" :
> + "alarms up to one day",
Could you reformat that so it looks more like the compound-IF
statement it really is? That is, display the nesting structure.
And not use negative logic for that first test.
next prev parent reply other threads:[~2009-04-04 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 16:52 [PATCH] fix RTC-CMOS message Krzysztof Halasa
2009-04-02 16:57 ` [PATCH] fix RTC-CMOS message, now with SOB Krzysztof Halasa
2009-04-04 18:02 ` David Brownell [this message]
2009-04-04 19:32 ` Krzysztof Halasa
2009-04-09 20:15 ` Andrew Morton
2009-04-14 21:53 ` Krzysztof Halasa
2009-04-15 13:31 ` [PATCH] fix RTC-CMOS message, against 2.6.30-rc2 Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904041102.07751.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.