All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Thiemo Nagel <thiemo.nagel@ph.tum.de>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH] off-by-one in "Add checks to validate extent entries."
Date: Sat, 4 Apr 2009 23:24:38 -0400	[thread overview]
Message-ID: <20090405032438.GI7553@mit.edu> (raw)
In-Reply-To: <49D4F217.7050105@ph.tum.de>

On Thu, Apr 02, 2009 at 07:12:55PM +0200, Thiemo Nagel wrote:
> Theodore Tso wrote:
> > I haven't had time yet to check your other patches; could you also
> > take a quick scan to make sure we have all of the byte-swapping calls
> > needed for proper big-endian checking, that we're using the correct
> > __le32 types and not doing any casts?
>
> I had a look at all patches I have sent, but I didn't notice anything  
> suspicious.  While doing that, however I think I found an off-by-one in
> 56b19868aca856a7d7bf20c3a7a1030e4fd75b2b

In the future, could you please remember to include a Signed-off-by:
for your patches?

Thanks!!

This one is simple enough that I'll just include it, but I'd really
prefer to get explicit signed-off patches.

						- Ted

  reply	other threads:[~2009-04-05  4:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02 17:12 [PATCH] off-by-one in "Add checks to validate extent entries." Thiemo Nagel
2009-04-05  3:24 ` Theodore Tso [this message]
2009-04-05 10:21   ` Thiemo Nagel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090405032438.GI7553@mit.edu \
    --to=tytso@mit.edu \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=thiemo.nagel@ph.tum.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.