From: Clark Williams <williams@redhat.com>
To: GeunSik Lim <leemgs1@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: cyclictest - fix comparison about flexible word counts of available_tracers file.
Date: Sun, 5 Apr 2009 09:50:01 -0500 [thread overview]
Message-ID: <20090405095001.6dc50fbc@torg> (raw)
In-Reply-To: <49b7c2350904042345x574edfcbx553ba1caccb8bd06@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Sun, 5 Apr 2009 15:45:33 +0900
GeunSik Lim <leemgs1@gmail.com> wrote:
> Dear Thomas,
>
> I found bug at settracer function of cyclictest.c source (rt-test ver 0.33).
> settracer func use 10 times in the for() statement to searching tracer
> like preemptoff , irqsoff , preemptirqsoff.
> But, I think that we have to consider 10+ words in the available_tracers file.
>
GeunSik,
Good catch! I applied your patch, but then found a bug in either
fscanf or debugfs (probably debugfs). Since I didn't have IRQSOFF or
PREEMPTOFF set in my kernel, those tracers weren't available and fscanf
never returned EOF (it kept returning the "nop" tracer). So I reworked
your patch to read everything in and parse it using strtok(3).
The git tree has been updated and an rt-tests-0.34.tar.gz tarball is
available at:
http://www.kernel.org/pub/linux//kernel/people/clrkwllms/rt-tests/
Clark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (GNU/Linux)
iEYEARECAAYFAknYxR4ACgkQHyuj/+TTEp3TNwCbBNrEHMLjPmAS6JciwjyXWqME
wpcAn3+nUGdOwCJR6sFGfwundPtaITrk
=dT+3
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2009-04-05 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 6:45 cyclictest - fix comparison about flexible word counts of available_tracers file GeunSik Lim
2009-04-05 14:05 ` Thomas Gleixner
2009-04-05 14:50 ` Clark Williams [this message]
2009-04-06 2:49 ` GeunSik Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090405095001.6dc50fbc@torg \
--to=williams@redhat.com \
--cc=leemgs1@gmail.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.