From: Rusty Russell <rusty@rustcorp.com.au>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Alex Williamson <alex.williamson@hp.com>,
netdev@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: virtio_net: MAC address releated breakage if there is no MAC area in config
Date: Sun, 5 Apr 2009 14:11:07 +1030 [thread overview]
Message-ID: <200904051311.08114.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200904021333.25119.borntraeger@de.ibm.com>
On Thursday 02 April 2009 22:03:24 Christian Borntraeger wrote:
> I read this as the mac config field is optional (similar to all the optional
> fields we added in virtio_blk later).
>
> I see two options:
> 1. Change our sample userspace to always allocate the config (like lguest and
> qemu)
> 2. Change the kernel code to not write into the config unless a specific feature
> bit is set. (e.g. VIRTIO_NET_F_SETMAC)
I had assumed it would always exist. Agreed it's unclear; I'm currently
writing down the actual standard to avoid such mistakes in the future.
Cheers,
Rusty.
prev parent reply other threads:[~2009-04-05 3:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 11:33 virtio_net: MAC address releated breakage if there is no MAC area in config Christian Borntraeger
2009-04-02 16:06 ` Alex Williamson
2009-04-02 17:23 ` Christian Borntraeger
2009-04-04 23:40 ` David Miller
2009-04-05 13:19 ` Rusty Russell
2009-04-05 3:41 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904051311.08114.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=alex.williamson@hp.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.