All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@redhat.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>, gnb@sgi.com
Subject: Re: [PATCH] Resurrect old pr_debug() semantics as pr_devel()
Date: Mon, 6 Apr 2009 17:24:17 -0400	[thread overview]
Message-ID: <20090406212417.GC3212@redhat.com> (raw)
In-Reply-To: <4a5c6b4cd1b77ebe6d60362bc982f4dc81cba85e.1238992196.git.michael@ellerman.id.au>

On Mon, Apr 06, 2009 at 02:30:03PM +1000, Michael Ellerman wrote:
> pr_debug() used to produce zero code unless DEBUG was #defined. This is
> now no longer the case in practice[1].
> 
> There are places where it's useful to have debugging printks, but we
> don't want them to generate any code in production kernels.
> 
> So add a new macro, pr_devel(), for _devel_opment, to provide the old
> semantics, ie. if the programmer doesn't explicitly enable debugging,
> no code is produced.
> 
> [1]: You can turn CONFIG_DYNAMIC_DEBUG off, but it's enabled in at least
>      one distro kernel, so it's not really a solution.
> 

hmm...its designed to have low overhead when CONFIG_DYNAMIC_DEBUG
is on, but none of the debugging printks are enabled. Is there a
specific benchmark or test case that is unaccpetable?

thanks,

-Jason

  reply	other threads:[~2009-04-06 21:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06  4:30 [PATCH] Resurrect old pr_debug() semantics as pr_devel() Michael Ellerman
2009-04-06 21:24 ` Jason Baron [this message]
2009-04-07  2:08   ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090406212417.GC3212@redhat.com \
    --to=jbaron@redhat.com \
    --cc=akpm@osdl.org \
    --cc=gnb@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.