Re: [PATCH 001/003] USB: serial: sierra driver performance improvements

[Greg KH <gregkh@suse.de>]

On Mon, Apr 06, 2009 at 05:05:54PM -0700, Elina wrote:
> Subject: [PATCH 001/003] USB: serial: sierra driver performance
> improvements
> From: Elina Pasheva <epasheva@sierrawireless.com>
> 
> The series of 3 patches modify sierra usb serial driver with
> performance improvements, blacklisting of specific non-serial 
> interfaces and bug fixing. 
> The following is summary of changes we have made to sierra.c driver in
> [PATCH 001/003] dealing with performance improvements:

You do a lot of different things in this patch, care to split it up into
tinier pieces, one per change?

> - Updated Copyright notice with new authors names
> - Version number set to 1.6.0
> - Increased the number of input/output URBs for improved performance
> (numbers based on an measurement study triggered by a user request).
> - Removed “no_dynamic_id=1” setting. Removing this setting will allow
> customers to add support for new modems via a system call (i.e. adding
> unrecognized PIDs) instead of having to download and build/install the
> driver for the new modem

This is incorrect, that value is an override for the usb driver, not the
usb-serial layer.  It should work today, just fine, to add a device id
after the driver is loaded dynamically through sysfs.  If not, please
let me know and I'll be glad to work on fixing it, but this is not the
correct way do to it.

Also, USB patches should be cc:ed to the linux-usb mailing list, I
really doubt that linux-kernel cares about tiny driver specific things
like this :)

Care to redo this whole series?

thanks,

greg k-h