From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Consolidate init_mm definition
Date: Tue, 7 Apr 2009 14:11:56 -0700 [thread overview]
Message-ID: <20090407141156.296d0d0c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090326235116.GA26129@x200.localdomain>
On Fri, 27 Mar 2009 02:51:16 +0300
Alexey Dobriyan <adobriyan@gmail.com> wrote:
> --- /dev/null
> +++ b/mm/init-mm.c
> @@ -0,0 +1,13 @@
> +#include <linux/mm_types.h>
> +#include <asm/pgtable.h>
> +
> +struct mm_struct init_mm = {
> + .mm_rb = RB_ROOT,
> + .pgd = swapper_pg_dir,
> + .mm_users = ATOMIC_INIT(2),
> + .mm_count = ATOMIC_INIT(1),
> + .mmap_sem = __RWSEM_INITIALIZER(init_mm.mmap_sem),
> + .page_table_lock = __SPIN_LOCK_UNLOCKED(init_mm.page_table_lock),
> + .mmlist = LIST_HEAD_INIT(init_mm.mmlist),
> + .cpu_vm_mask = CPU_MASK_ALL,
> +};
I'd be more conmfortable if this file were to explicitly include the
headers which it needs.
As it stands, variations in configs (especially different
architectures) have a decent chance of breaking things.
prev parent reply other threads:[~2009-04-07 21:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 23:51 [PATCH] Consolidate init_mm definition Alexey Dobriyan
2009-03-27 0:05 ` Mike Frysinger
2009-03-27 1:56 ` Alexey Dobriyan
2009-03-27 3:54 ` Mike Frysinger
2009-03-29 16:38 ` Américo Wang
2009-03-29 17:59 ` Alexey Dobriyan
2009-04-07 21:11 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090407141156.296d0d0c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.