From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: "figo.zhang" <figo.zhang@kolorific.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, rdunlap@xenotime.net
Subject: Re: [PATCH]kernel/sched_fair.c: the comment of the calc_delta_fair() maybe not correctly
Date: Wed, 8 Apr 2009 00:57:36 +0800 [thread overview]
Message-ID: <20090407165736.GI12226@hack> (raw)
In-Reply-To: <20090407063306.64659F50054@mail.kolorific.com>
On Tue, Apr 07, 2009 at 02:33:06PM +0800, figo.zhang wrote:
>the comment of the calc_delta_fair() maybe not correctly, should be
>delta *= NICE_O_LOAD/se->load
>
>Signed-off-by: figo.zhang <figo.zhang@kolorific.com>
Agreed.
But...
>
>diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
>index 3816f21..5134b45 100644
>--- a/kernel/sched_fair.c
>+++ b/kernel/sched_fair.c
>@@ -386,7 +386,7 @@ int sched_nr_latency_handler(struct ctl_table
>*table, int write, #endif
>
> /*
>- * delta /= w
>+ * delta *= NICE_O_LOAD/se->load
Is that an 'O' or '0'(zero)? It looks like an 'O' for me ...
Obviously, it should be '0' (zero). :)
> */
> static inline unsigned long
> calc_delta_fair(unsigned long delta, struct sched_entity *se)
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
--
Do what you love, f**k the rest! F**k the regulations!
next prev parent reply other threads:[~2009-04-07 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 6:33 [PATCH]kernel/sched_fair.c: the comment of the calc_delta_fair() maybe not correctly figo.zhang
2009-04-07 16:57 ` Américo Wang [this message]
2009-04-08 2:27 ` figo.zhang
2009-04-08 9:53 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090407165736.GI12226@hack \
--to=xiyou.wangcong@gmail.com \
--cc=figo.zhang@kolorific.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.