From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LrHRy-0002B8-Av
	for qemu-devel@nongnu.org; Tue, 07 Apr 2009 15:59:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LrHRx-0002Ad-Hz
	for qemu-devel@nongnu.org; Tue, 07 Apr 2009 15:59:13 -0400
Received: from [199.232.76.173] (port=47882 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LrHRx-0002AY-DU
	for qemu-devel@nongnu.org; Tue, 07 Apr 2009 15:59:13 -0400
Received: from hall.aurel32.net ([88.191.82.174]:52995)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1LrHRw-0004d0-RF
	for qemu-devel@nongnu.org; Tue, 07 Apr 2009 15:59:13 -0400
Date: Tue, 7 Apr 2009 21:59:09 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] Fix incorrect attempt to clear a flag in
	vnc.c
Message-ID: <20090407195909.GC23682@volta.aurel32.net>
References: <4996BD8A.2050807@moose.net> <49973240.2070106@codemonkey.ws>
	<499735B3.3020401@egenera.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <499735B3.3020401@egenera.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Brian Kress <kressb@moose.net>
Cc: qemu-devel@nongnu.org

On Sat, Feb 14, 2009 at 04:20:51PM -0500, Brian Kress wrote:
> Anthony Liguori wrote:
>> Brian Kress wrote:
>>> In vnc.c in pixel_format_message, the code tries to clear the  
>>> QEMU_ALLOCATED_FLAG
>>> from the client display surface, however it uses the wrong operator  
>>> and ends up enabling all
>>> other flags.  Most notably this enables the big endian flag and  
>>> causes some chaos.
>> Can you add a Signed-off-by line?
>>
> Signed-off-by: Brian Kress <kressb@moose.net>

Thanks, applied.

> Index: vnc.c
> ===================================================================
> --- vnc.c	(revision 6619)
> +++ vnc.c	(working copy)
> @@ -1421,7 +1421,7 @@
>     else if (vs->ds->surface->pf.bits_per_pixel == 8)
>         vs->send_hextile_tile = send_hextile_tile_8;
>     vs->clientds = *(vs->ds->surface);
> -    vs->clientds.flags |= ~QEMU_ALLOCATED_FLAG;
> +    vs->clientds.flags &= ~QEMU_ALLOCATED_FLAG;
>     vs->write_pixels = vnc_write_pixels_copy;
>
>     vnc_write(vs, pad, 3);           /* padding */
>
>
>
>

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net