From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH -tip] x86: do_IRQ - send EOI for x86-32 on irq without handler v2
Date: Wed, 8 Apr 2009 16:52:18 +0200 [thread overview]
Message-ID: <20090408145218.GM12931@elte.hu> (raw)
In-Reply-To: <20090408145017.GB7556@lenovo>
* Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> Ingo, I think introducing additional dummy here would be a bit
> expencive -- a number of callers of ack_APIC_irq just should not
> check for disable_apic since it's not needed. disable_apic is to
> depend on CONFIG_X86_LOCAL_APIC rather then CONFIG_X86_64
> actually. So make it then. Or you mean something else? Like new
> apic->write_eoi operation? (I'm a bit tired so brain is a half
> functional now :)
no, i meant a dummy apic->write() method in the !apic case. Check
what ack_APIC_irq() does internally.
Ingo
next prev parent reply other threads:[~2009-04-08 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 14:50 [PATCH -tip] x86: do_IRQ - send EOI for x86-32 on irq without handler v2 Cyrill Gorcunov
2009-04-08 14:52 ` Ingo Molnar [this message]
2009-04-08 15:45 ` Cyrill Gorcunov
2009-04-08 15:55 ` Ingo Molnar
2009-04-08 16:21 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408145218.GM12931@elte.hu \
--to=mingo@elte.hu \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.