All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	yinghai@kernel.org, tglx@linutronix.de, mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/apic] x86: make wakeup_secondary_cpu_via_init static
Date: Wed, 8 Apr 2009 22:39:24 +0400	[thread overview]
Message-ID: <20090408183924.GF7556@lenovo> (raw)
In-Reply-To: <tip-cdc1cb0d4445f39561a65204d26f89365f917550@git.kernel.org>

[Yinghai Lu - Wed, Apr 08, 2009 at 01:00:32PM +0000]
| Commit-ID:  cdc1cb0d4445f39561a65204d26f89365f917550
| Gitweb:     http://git.kernel.org/tip/cdc1cb0d4445f39561a65204d26f89365f917550
| Author:     Yinghai Lu <yinghai@kernel.org>
| AuthorDate: Fri, 3 Apr 2009 17:15:14 -0700
| Committer:  Ingo Molnar <mingo@elte.hu>
| CommitDate: Wed, 8 Apr 2009 14:50:28 +0200
| 
| x86: make wakeup_secondary_cpu_via_init static
| 
| Impact: cleanup
| 
| Signed-off-by: Yinghai Lu <yinghai@kernel.org>
| LKML-Reference: <49D6A692.6040400@kernel.org>
| Signed-off-by: Ingo Molnar <mingo@elte.hu>
| 
| 
| ---
|  arch/x86/kernel/smpboot.c |    2 +-
|  1 files changed, 1 insertions(+), 1 deletions(-)
| 
| diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
| index 58d24ef..bddf2cc 100644
| --- a/arch/x86/kernel/smpboot.c
| +++ b/arch/x86/kernel/smpboot.c
| @@ -538,7 +538,7 @@ wakeup_secondary_cpu_via_nmi(int logical_apicid, unsigned long start_eip)
|  	return (send_status | accept_status);
|  }
|  
| -int __devinit
| +static int __devinit
|  wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
|  {
|  	unsigned long send_status, accept_status = 0;

Hi Yinghai,

just curious why it's not __cpuinit? Did I miss something?

       Cyrill

  reply	other threads:[~2009-04-08 18:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-04  0:13 [PATCH] x86: make 64 bit to use default_inquire_remote_apic Yinghai Lu
2009-04-04  0:15 ` [PATCH] x86: make wakeup_secondary_cpu_via_init static Yinghai Lu
2009-04-04  0:15   ` [PATCH] x86: consistent about warm_reset_vector for UN_NON_UNIQUE_APIC Yinghai Lu
2009-04-08 13:00     ` [tip:x86/apic] " Yinghai Lu
2009-04-08 13:00   ` [tip:x86/apic] x86: make wakeup_secondary_cpu_via_init static Yinghai Lu
2009-04-08 18:39     ` Cyrill Gorcunov [this message]
2009-04-08 19:10       ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090408183924.GF7556@lenovo \
    --to=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.