From: Greg KH <gregkh@suse.de>
To: Alexey Klimov <klimov.linux@gmail.com>
Cc: David Vrabel <david.vrabel@csr.com>,
linux-usb@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] usb: add reset endpoint operations
Date: Wed, 8 Apr 2009 16:40:25 -0700 [thread overview]
Message-ID: <20090408234025.GA28532@suse.de> (raw)
In-Reply-To: <208cbae30904081636x71e7675egad7566bc601cb2cf@mail.gmail.com>
On Thu, Apr 09, 2009 at 03:36:51AM +0400, Alexey Klimov wrote:
> (added linux-media maillist)
>
> Hello, David
>
> On Wed, Apr 8, 2009 at 9:36 PM, David Vrabel <david.vrabel@csr.com> wrote:
> > Wireless USB endpoint state has a sequence number and a current
> > window and not just a single toggle bit. So allow HCDs to provide a
> > endpoint_reset method and call this or clear the software toggles as
> > required (after a clear halt, set configuration etc.).
> >
> > usb_settoggle() and friends are then HCD internal and are moved into
> > core/hcd.h and all device drivers call usb_reset_endpoint() instead.
> >
> > If the device endpoint state has been reset (with a clear halt) but
> > the host endpoint state has not then subsequent data transfers will
> > not complete. The device will only work again after it is reset or
> > disconnected.
> >
> > Signed-off-by: David Vrabel <david.vrabel@csr.com>
> > ---
> > drivers/block/ub.c | 20 ++++-----
> > drivers/isdn/hisax/st5481_usb.c | 9 +----
> > drivers/media/video/pvrusb2/pvrusb2-hdw.c | 1 -
>
> Looks like you change file under /drivers/video. It's better at least
> to add linux-media maillist or driver maintainer (not only linux-usb
> list) to let developers know that you change drivers.
He's already gotten an Ack from this driver author on the last time this
patch was sent out. Don't know why he forgot to add it to this version
of the patch, it should still be valid :)
thanks,
greg k-h
next prev parent reply other threads:[~2009-04-08 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1239212193-27618-1-git-send-email-david.vrabel@csr.com>
[not found] ` <1239212193-27618-2-git-send-email-david.vrabel@csr.com>
2009-04-08 23:36 ` [PATCH] usb: add reset endpoint operations Alexey Klimov
2009-04-08 23:40 ` Greg KH [this message]
2009-04-08 23:57 ` Alexey Klimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408234025.GA28532@suse.de \
--to=gregkh@suse.de \
--cc=david.vrabel@csr.com \
--cc=klimov.linux@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.