From: Andrea Righi <righi.andrea@gmail.com>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Krzysztof Helt <krzysztof.h1@poczta.fm>,
Andrew Morton <akpm@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Andrey Borzenkov <arvidjaar@gmail.com>,
"Antonino A. Daplas" <adaplas@gmail.com>,
linux-fbdev-devel@lists.sourceforge.net,
linux-pm@lists.linux-foundation.org,
Dave Jones <davej@redhat.com>,
Harvey Harrison <harvey.harrison@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: Re: [REGRESSION] commit 66c1ca0: {fbmem: fix fb_info->lock and mm->mmap_sem ...} causes Xfbdev not working
Date: Thu, 9 Apr 2009 14:58:51 +0200 [thread overview]
Message-ID: <20090409125850.GA2727@linux> (raw)
In-Reply-To: <f17812d70904090436kd03744brca4a4bc4b85bba8@mail.gmail.com>
On Thu, Apr 09, 2009 at 07:36:24PM +0800, Eric Miao wrote:
> This happens on my Marvell PXA310-based Littleton platform with
> Angstrom Distribution. The offending paths are many:
>
> FBIOPUT_VSCREENINFO:
> lock_fb_info()
> --> fb_set_var()
> --> fb_notifier_call_chain() [FBINFO_MISC_USEREVENT]
> --> fbcon_event_notifier() [FB_EVENT_MODE_CHANGE]
> --> lock_fb_info()
>
> OK, now hang. I'd suggest a clean fix to the original assumption of
> circular locking
> issue and revert this commit first.
>
> --
> Cheers
> - eric
I can agree to revert 66c1ca019078220dc1bf968f2bb18421100ef147, since I
don't have a clean fix for this. Pushing down fb_info->lock in
fb_set_var() excluding to call fb_notifier_call_chain with fb_info->lock
held doesn't seem to be so trivial...
However, reverting this will re-introduce the circular locking
dependency fb_info->lock => mm->mmap_sem => fb_info->lock.
-Andrea
next prev parent reply other threads:[~2009-04-09 12:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 11:36 [REGRESSION] commit 66c1ca0: {fbmem: fix fb_info->lock and mm->mmap_sem ...} causes Xfbdev not working Eric Miao
2009-04-09 12:58 ` Andrea Righi
2009-04-09 12:58 ` Andrea Righi [this message]
2009-04-10 20:21 ` Krzysztof Helt
2009-04-10 21:16 ` Andrew Morton
2009-04-10 21:16 ` Andrew Morton
2009-04-10 22:05 ` Andrea Righi
2009-04-10 22:05 ` Andrea Righi
2009-04-11 6:04 ` Krzysztof Helt
2009-04-11 9:00 ` Stefan Richter
2009-04-11 11:08 ` Andrea Righi
2009-04-11 11:08 ` Andrea Righi
2009-04-11 15:04 ` Andrea Righi
2009-04-11 15:04 ` Andrea Righi
2009-04-11 18:21 ` Andrew Morton
2009-04-11 18:21 ` Andrew Morton
2009-04-11 19:32 ` Andrea Righi
2009-04-11 19:32 ` Andrea Righi
2009-04-13 23:34 ` Andreas Schwab
2009-04-13 23:34 ` Andreas Schwab
2009-04-17 16:25 ` Krzysztof Helt
[not found] ` <20090417182507.0bd85ccc.krzysztof.h1@poczta.fm>
2009-04-17 22:51 ` Andrea Righi
2009-04-17 22:51 ` Andrea Righi
2009-04-11 15:04 ` Andrea Righi
2009-04-11 9:00 ` Stefan Richter
2009-04-11 6:04 ` Krzysztof Helt
2009-04-10 20:21 ` Krzysztof Helt
2009-04-10 17:40 ` Krzysztof Helt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090409125850.GA2727@linux \
--to=righi.andrea@gmail.com \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arvidjaar@gmail.com \
--cc=davej@redhat.com \
--cc=eric.y.miao@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hannes@cmpxchg.org \
--cc=harvey.harrison@gmail.com \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.