From: Matthew Garrett <mjg@redhat.com>
To: Rafi Rubin <rafi@seas.upenn.edu>
Cc: Len Brown <len.brown@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Additional keys for dell-wmi
Date: Thu, 9 Apr 2009 16:32:03 +0100 [thread overview]
Message-ID: <20090409153203.GB17194@srcf.ucam.org> (raw)
In-Reply-To: <200904082116.n38LG4Df012420@ampersand.seas.upenn.edu>
On Wed, Apr 08, 2009 at 05:16:04PM -0400, Rafi Rubin wrote:
> static struct key_entry dell_wmi_keymap[] = {
> {KE_KEY, 0xe045, KEY_PROG1},
> + {KE_KEY, 0xe046, KEY_PROG2},
> + {KE_KEY, 0xe047, KEY_PROG3},
Would this make more sense as a switch? That way userspace can know what
state the screen is in.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-04-09 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 21:16 [PATCH] Additional keys for dell-wmi Rafi Rubin
2009-04-09 8:22 ` Éric Piel
2009-04-09 12:14 ` [PATCH] Comments for additional " Rafi Rubin
2009-04-09 15:32 ` Matthew Garrett [this message]
2009-04-10 11:00 ` [PATCH] Additional " Éric Piel
2009-04-10 14:03 ` Rafi Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090409153203.GB17194@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafi@seas.upenn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.