From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [RFC v14-rc3][PATCH 36/36] Stub implementation of IPC namespace c/r Date: Thu, 9 Apr 2009 16:29:39 -0500 Message-ID: <20090409212939.GD5115@us.ibm.com> References: <1239107264-21775-1-git-send-email-orenl@cs.columbia.edu> <1239107264-21775-37-git-send-email-orenl@cs.columbia.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1239107264-21775-37-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oren Laadan Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Dan Smith , Dave Hansen List-Id: containers.vger.kernel.org Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org): > From: Dan Smith > > Changes: > - Update to match UTS changes > > Signed-off-by: Dan Smith > Signed-off-by: Oren Laadan Acked-by: Serge Hallyn However... > + if (!!ipc_ns ^ !(flags & CLONE_NEWIPC)) > + return -EINVAL; Every time I see this I have to think about whether it is right or not. I'm not sure whether it's worth commenting (at each such meme) that CLONE_NEWIPC only needed to be set the first time we ran across that ipcns, or whether it's indicative that there is a simpler way the code could be done. But if it just took me a twice-over to see that it's right, when I'd already confirmed that with the CLONE_NEWUTS version last week, then a fresh reviewer will be cursing your name... -serge