From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled
Date: Fri, 10 Apr 2009 00:58:20 +0200 [thread overview]
Message-ID: <20090410005820.4fcfcc1f@i1501.lan.towertech.it> (raw)
In-Reply-To: <20090409153921.04b6384c.akpm@linux-foundation.org>
On Thu, 9 Apr 2009 15:39:21 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> > The rtc_update_irq() might be called with irqs enabled, if a interrupt
> > handler was registered without IRQF_DISABLED.
>
> Why? What are the consequences of not merging the patch? Is it a
> bugfix? If so, what are the user-visible effects of the bug?
rtc_update_irq() is called by a driver, and a driver
is supposed to know when it's doing the call.
The driver can either use IRQF_DISABLED or disable the
interrupts in some other ways.
I also suspect this is some legacy we are carrying on,
so it's better to leave the decision on the interrupt
handling to the driver itself.
Unless I'm missing something.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2009-04-09 22:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 16:50 [PATCH] rtc: Make rtc_update_irq callable with irqs enabled Atsushi Nemoto
2009-04-09 22:39 ` Andrew Morton
2009-04-09 22:58 ` Alessandro Zummo [this message]
2009-04-23 14:51 ` Atsushi Nemoto
2009-04-23 15:02 ` Alessandro Zummo
2009-04-23 15:07 ` [rtc-linux] " Mike Frysinger
[not found] ` <200904091627.15776.david-b@pacbell.net>
2009-04-23 15:29 ` Atsushi Nemoto
2009-04-23 15:46 ` Alessandro Zummo
2009-04-23 18:15 ` David Brownell
2009-04-23 18:27 ` [rtc-linux] " Alessandro Zummo
2009-04-23 19:02 ` David Brownell
2009-04-23 19:09 ` Alessandro Zummo
2009-04-23 19:25 ` David Brownell
2009-04-23 19:26 ` Alessandro Zummo
2009-04-23 19:45 ` David Brownell
2009-04-23 19:55 ` Alessandro Zummo
2009-04-24 9:31 ` David Brownell
2009-04-24 10:01 ` Alessandro Zummo
2009-04-24 11:10 ` David Brownell
2009-04-24 11:13 ` Alessandro Zummo
2009-04-24 16:48 ` Atsushi Nemoto
2009-04-24 17:06 ` Atsushi Nemoto
2009-04-24 19:41 ` Alessandro Zummo
2009-04-25 12:40 ` Atsushi Nemoto
2009-04-28 13:13 ` Hans-Christian Egtvedt
2009-04-28 15:56 ` Atsushi Nemoto
2009-04-23 15:37 ` Alessandro Zummo
2009-04-23 16:30 ` Mike Frysinger
2009-04-23 16:40 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090410005820.4fcfcc1f@i1501.lan.towertech.it \
--to=alessandro.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.