From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ls3dN-0007r8-7B for mharc-grub-devel@gnu.org; Thu, 09 Apr 2009 19:26:13 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ls3dL-0007qO-KG for grub-devel@gnu.org; Thu, 09 Apr 2009 19:26:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ls3dK-0007pz-SG for grub-devel@gnu.org; Thu, 09 Apr 2009 19:26:11 -0400 Received: from [199.232.76.173] (port=44325 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ls3dK-0007ps-LN for grub-devel@gnu.org; Thu, 09 Apr 2009 19:26:10 -0400 Received: from mail.nexedi.com ([91.121.25.85]:44929 helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ls3dK-0005Qp-8M for grub-devel@gnu.org; Thu, 09 Apr 2009 19:26:10 -0400 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 211DD3D9EF for ; Fri, 10 Apr 2009 01:26:08 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Fri, 10 Apr 2009 08:26:10 +0900 User-Agent: KMail/1.9.10 References: <200904041830.27016.okuji@enbug.org> <200904070937.47193.okuji@enbug.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904100826.10820.okuji@enbug.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: no commit allowed under discussion X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2009 23:26:11 -0000 On Tuesday 07 April 2009 14:25:53 Bean wrote: > On Tue, Apr 7, 2009 at 8:37 AM, Yoshinori K. Okuji wrote: > > On Tuesday 07 April 2009 01:43:17 Bean wrote: > >> On Sat, Apr 4, 2009 at 8:53 PM, Bean wrote: > >> > On Sat, Apr 4, 2009 at 5:30 PM, Yoshinori K. Okuji > > > > wrote: > >> >> I've undone r2063, since we're still discussing how to / not to split > >> >> modules. Bean, you must respect teamwork. If you are unable to follow > >> >> such a fundamental rule, I will have to disable your permission. > >> > > >> > Hi, > >> > > >> > I thought the previous mail is about replacing grub_printf with > >> > grub_dprint, I'm ok with that. This patch has been in mail list for > >> > sometime, it is essential to get a working display in intel macs. > >> > >> Hi, > >> > >> How about this patch ? The split is necessary as it introduces new > >> command loadbios and fakebios that uses the fake_bios_data function, > >> and it would be ugly to put them all inside linux.c. > > > > Do you have any strong reason to make loadbios and fakebios separate? I > > think the overhead is negligible. > > Hi, > > loadbios and fakebios are sort of like hacks for the efi platform, I > think they shouldn't be placed in the linux loader. Also, by moving > the platform dependent code out, we can merge it with i386 generic > loader loader/i386/linux.c. I reviewed your patch again, and I confirmed that it was good. Thanks. Regards, Okuji