From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ls40Q-0003Oi-2r for mharc-grub-devel@gnu.org; Thu, 09 Apr 2009 19:50:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ls40O-0003OQ-1m for grub-devel@gnu.org; Thu, 09 Apr 2009 19:50:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ls40N-0003OE-Dp for grub-devel@gnu.org; Thu, 09 Apr 2009 19:49:59 -0400 Received: from [199.232.76.173] (port=51610 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ls40N-0003O9-6B for grub-devel@gnu.org; Thu, 09 Apr 2009 19:49:59 -0400 Received: from mail.nexedi.com ([91.121.25.85]:41853 helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ls40M-0007m8-PJ for grub-devel@gnu.org; Thu, 09 Apr 2009 19:49:58 -0400 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 73EB23D9F7 for ; Fri, 10 Apr 2009 01:49:56 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Fri, 10 Apr 2009 08:49:57 +0900 User-Agent: KMail/1.9.10 References: <200904060043.03075.okuji@enbug.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904100849.57251.okuji@enbug.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Split of normal mode (version 2) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2009 23:50:00 -0000 On Tuesday 07 April 2009 01:39:23 Bean wrote: > Hi, > > This is another update of the patch. > > 1, Now completion.c is in menu.mod, and menu_viewer.c is in misc.mod, > the reason for the switch is to allow configfile to depend on misc.mod > only. I think the name "misc.mod" is ugly. Can you think about a better name? > 2, Auto generate handler.lst file, which contain module information > for handlers. normal.mod uses it to register commands to set active > handler, for example: > > parser.sh > menu_viewer.text > terminal_output.gfxterm Great. > 3, configfile now support an optional parameter to specify the script > engine, for example: > > configfile /aa.cfg sh > > When configfile returns, the script engine would be restored to the > previous value. This is useful for switching script engine. For > example, you can parse a file in another language, then switch back to > sh for the rest of grub.cfg. I object to the syntax, but not to the idea. "configfile" is GRUB-specific, so it might be acceptable. But IIRC the underlying function is shared with "source", right? In Bourne Shell, "source FILE ARG" means that the file FILE is executed with a positional argument ARG. So it is not intuitive to specify a parser this way. I proposed using a shebang some days ago. Was it so bad? > 4, normal.mod set the default parser and menu viewer before parsing > grub.cfg: parser.sh > menu_viewer.text Regards, Okuji