Re: [Qemu-devel] [PATCH] qemu-io: Verify read data by patterns

[Kevin Wolf <mail@kevin-wolf.de>]

Am Freitag, 10. April 2009 18:15 schrieb Christoph Hellwig:
> On Thu, Apr 09, 2009 at 12:54:09PM -0500, Anthony Liguori wrote:
> > The only reason I merged it as-is is because the code was derived from
> > something else.  I didn't want to force a reindentation that would make
> > it harder to keep the code synced against the upstream project.
>
> The one where I really don't want to change it is cmd.[ch] as it's a 1:1
> copy from libxcmd.  While qemu-io.c is derived from xfs_io it already
> has diverged a lot and will even more.

Sounds like a good idea then to convert qemu-io.c and leave the rest as it is. 
I guess that cmd.[ch] won't be changed too often compared to qemu-io.c, so 
it's much less annoying there.

Anthony, would you accept a patch converting tabs to spaces in qemu-io.c? Or 
maybe you want to do it yourself?

Kevin