From: Mark Levedahl <mlevedahl@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin-branch - allow deleting a fully specified branch-name
Date: Sat, 11 Apr 2009 13:01:30 -0400 [thread overview]
Message-ID: <200904111301.31250.mlevedahl@gmail.com> (raw)
In-Reply-To: <7vbpr519jq.fsf@gitster.siamese.dyndns.org>
On Thursday 09 April 2009 23:18:01 you wrote:
>
> All other commands happen to take a branch name because that is just one
> case of extended SHA-1 expression to name an object. In that context, a
> refname (which a branch name is a special case of) refers to the commit
> pointed by it. E.g.
>
> "git checkout HEAD~20 -- Makefile"
> "git show refs/heads/foo"
> "git show heads/foo"
> "git show foo"
I think my underlying problem here is the porcelain's ability to use either a
branch name or a ref name, in different contexts, leading to a sometimes
inconsistent interface. Consider the following
$ git checkout master
checks out branch master
$ git checkout refs/heads/master
checks out commit pointed to by refs/heads/master on a detached
HEAD
$ git checkout -b refs/heads/master refs/heads/master
creates a new branch, refname = refs/heads/refs/heads/master
The last command is the one that I find most curious. The exact same string
has two entirely different meanings to the same command. I can explain why
this happens, but I cannot explain why this is a good thing.
A model I could explain without mental gymnastics would be "branch names are
simply refnames without the leading refs/heads or refs/remotes, and a refname
may be used wherever a branch name is requested. While branch names are
potentially ambiguous, refnames never are." Of course, this would mean that
the refs/heads/refs/... namespace is illegal. I don't know of any other
downside (except of course to someone using that namespace), and frankly I
don't think the existence of the refs/heads/refs namespace is a good thing,
given the potential for confusion.
Just a thought.
Mark
next prev parent reply other threads:[~2009-04-11 17:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 0:28 [PATCH] builtin-branch - allow deleting a fully specified branch-name Mark Levedahl
2009-04-10 0:39 ` Junio C Hamano
2009-04-10 1:19 ` Mark Levedahl
2009-04-10 3:18 ` Junio C Hamano
2009-04-11 17:01 ` Mark Levedahl [this message]
2009-04-12 7:20 ` Jeff King
2009-04-12 8:22 ` Junio C Hamano
2009-04-13 8:56 ` Jeff King
2009-04-13 9:54 ` Junio C Hamano
2009-04-13 11:09 ` Jeff King
2009-04-13 11:11 ` [PATCH 1/5] doc: clarify --no-track option Jeff King
2009-04-13 11:11 ` [PATCH 2/5] doc: refer to tracking configuration as "upstream" Jeff King
2009-04-13 11:18 ` [PATCH 3/5] doc/checkout: refer to git-branch(1) as appropriate Jeff King
2009-04-13 11:19 ` [PATCH 4/5] doc/checkout: split checkout and branch creation in synopsis Jeff King
[not found] ` <fabb9a1e0904130613g5b664706jb6a3c29107ac1fc9@mail.gmail.com>
2009-04-13 13:19 ` Jeff King
2009-04-13 13:21 ` Sverre Rabbelier
2009-04-13 11:21 ` [PATCH 5/5] docs/checkout: clarify what "non-branch" means Jeff King
2009-04-13 16:31 ` Junio C Hamano
2009-04-14 3:40 ` Mark Levedahl
2009-04-14 4:20 ` Junio C Hamano
2009-04-14 11:36 ` Jakub Narebski
2009-04-15 18:00 ` Jeff King
2009-04-15 17:58 ` Jeff King
2009-04-13 10:57 ` [PATCH] builtin-branch - allow deleting a fully specified branch-name Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904111301.31250.mlevedahl@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.