From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LsZqv-0004Yq-EC for mharc-grub-devel@gnu.org; Sat, 11 Apr 2009 05:50:21 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LsZqt-0004Yl-GO for grub-devel@gnu.org; Sat, 11 Apr 2009 05:50:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LsZqq-0004YZ-Da for grub-devel@gnu.org; Sat, 11 Apr 2009 05:50:19 -0400 Received: from [199.232.76.173] (port=56673 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LsZqq-0004YW-4V for grub-devel@gnu.org; Sat, 11 Apr 2009 05:50:16 -0400 Received: from mail.nexedi.com ([91.121.25.85]:36594 helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LsZqp-0004E0-MF for grub-devel@gnu.org; Sat, 11 Apr 2009 05:50:15 -0400 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 009383D9FA for ; Sat, 11 Apr 2009 11:50:09 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 11 Apr 2009 18:50:14 +0900 User-Agent: KMail/1.9.10 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904111850.14993.okuji@enbug.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Split of normal mode (version 2) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2009 09:50:20 -0000 On Saturday 11 April 2009 05:17:43 Bean wrote: > Hi, > > Another update for the patch: > > sync with svn r2074 > misc bug fixes > change build script for i386-efi, i386-coreboot, i386-ieee1275 and > x86_64-efi as well as i386-pc, grub-emu now builds properly for > i386-pc. > support the use of #! in the script file. It would switch to the > selected parser, read the file, then restore to the original parser > before returning. > configfile/source now back to previous syntax, as there is no need to > change parser in here anymore. I am afraid that this patch is getting too big to review. Honestly, I would like you to check in some parts quickly, and the rest still requires more discussion. Anyway, I think it is a good practice to check in one thing at one time, so splitting the patch is a good thing. For example: - handler unification -> one patch - config embedding -> one patch - parser separation -> one patch - viewer separation -> one patch - misc module -> one patch - etc. Due to the volume, I am not certain if I have really read everything. :( Regards, Okuji