From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LsaFp-0000mQ-MU for mharc-grub-devel@gnu.org; Sat, 11 Apr 2009 06:16:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LsaFn-0000lA-0g for grub-devel@gnu.org; Sat, 11 Apr 2009 06:16:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LsaFm-0000kO-GF for grub-devel@gnu.org; Sat, 11 Apr 2009 06:16:02 -0400 Received: from [199.232.76.173] (port=50504 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LsaFm-0000kC-6e for grub-devel@gnu.org; Sat, 11 Apr 2009 06:16:02 -0400 Received: from mail.nexedi.com ([91.121.25.85]:33712 helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LsaFl-0000Qr-Sz for grub-devel@gnu.org; Sat, 11 Apr 2009 06:16:02 -0400 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 23D163D9FA for ; Sat, 11 Apr 2009 12:16:00 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 11 Apr 2009 19:16:05 +0900 User-Agent: KMail/1.9.10 References: <49DFDAB7.1080009@gmail.com> In-Reply-To: <49DFDAB7.1080009@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904111916.06107.okuji@enbug.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Preboot support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2009 10:16:03 -0000 On Saturday 11 April 2009 08:48:07 phcoder wrote: > Hello, here is the preboot hooks support. Apply on top of my bootmove > patch. They are very useful for patches like sendkey (my old patch that > I'll rediff), badram, acpi (2 patches in separate threads) or drivemap Some comments about the design. - register/unregister is more appropriate than add/remove. - preboot is ambigous. preboot_hook is better. - Using an int value for the priority is quetionable. Very often, this style of priority system leads to chaos, because everyone picks up arbitrary numbers randomly. I prefer to define enums with a careful analysis. Regards, Okuji