Re: [PATCH 1/2] ftrace: Separate include/trace/kmemtrace.h to kmemtrace part and tracepoint part

[Ingo Molnar <mingo@elte.hu>]

* Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> wrote:

> On Fri, Apr 10, 2009 at 01:03:03PM +0200, Ingo Molnar wrote:
> > 
> > * Zhaolei <zhaolei@cn.fujitsu.com> wrote:
> > 
> > > Current kmemtrace.h is used both as header file of kmemtrace and kmem's
> > > tracepoints definition.
> > > Tracepoints' definition file may be used by other code, and should only have
> > > definition of tracepoint.
> > > 
> > > We can separate include/trace/kmemtrace.h into 2 files:
> > >   include/linux/kmemtrace.h: header file for kmemtrace
> > >   include/trace/kmem.h:      definition of kmem tracepoints
> > > 
> > > Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
> > > ---
> > >  include/linux/kmemtrace.h             |   25 +++++++++++++++++++++++++
> > >  include/linux/slab_def.h              |    2 +-
> > >  include/linux/slub_def.h              |    2 +-
> > >  include/trace/{kmemtrace.h => kmem.h} |   25 +++----------------------
> > >  init/main.c                           |    2 +-
> > >  kernel/trace/kmemtrace.c              |    2 +-
> > >  kernel/trace/trace.h                  |    2 +-
> > >  mm/slab.c                             |    2 +-
> > >  mm/slob.c                             |    2 +-
> > >  mm/slub.c                             |    2 +-
> > >  10 files changed, 36 insertions(+), 30 deletions(-)
> > >  create mode 100644 include/linux/kmemtrace.h
> > >  rename include/trace/{kmemtrace.h => kmem.h} (78%)
> > 
> > Pekka, Eduard, do you agree with these two patches? Converting those 
> > tracepoints to TRACE_EVENT() is really nice. The above include file 
> > restructuring makes sense too - it separates tracepoint definition 
> > from the plugin init method.
> > 
> > 	Ingo
> 
> Yes, these two patches look great. The first one makes the 
> kmem tracepoints usable by other things (e.g. kmemcheck) 
> in a kmemtrace-independent fashion, which is nice. Thanks, 
> Zhao.
>
> One thing I don't actually get is why have kmem_event_types.h 
> separate from kmem.h, but it's not really an issue, I see other 
> tracers doing the same thing. Other than that, it looks fine 
> although I didn't test. Here's the ack if you need it:
> 
> Acked-by: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>

I've applied the patches to tip:tracing/ftrace - thanks guys!

The separation of kmem.h from kmem_event_types.h is mainly to keep 
the generic event definitions separate from other 'glue'. Indeed it 
looks a bit artificial here.

	Ingo