From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: hpa@zytor.com, tglx@linutronix.de, xemul@openvz.org,
yhlu.kernel@gmail.com, linux-kernel@vger.kernel.org,
macro@linux-mips.org, andi@firstfloor.org
Subject: Re: [rfc 1/4] x86: irq.c - tiny cleanup
Date: Sun, 12 Apr 2009 21:53:04 +0400 [thread overview]
Message-ID: <20090412175304.GC6942@lenovo> (raw)
In-Reply-To: <20090412172536.GB26459@elte.hu>
[Ingo Molnar - Sun, Apr 12, 2009 at 07:25:36PM +0200]
|
| * Cyrill Gorcunov <gorcunov@openvz.org> wrote:
|
| > Impact: cleanup
| >
| > 1) guard ack_bad_irq with printk_ratelimit since there is no
| > guarantee we will not be flooded one day
| > 2) use pr_emerg helper
| >
...
| Btw, this is not so theoretical - in the past i've had bugs where a
| flood of these messages made the system unusable. (granted, it would
| have been unusable even with rate-limiting - but it's still nice to
| have a throttle in place for something like this.)
|
| Ingo
|
I bet the only benefit is that a user will have
some time to pull out camera and snap screen
before it's scrolled with bad irq messages :)
Cyrill
next prev parent reply other threads:[~2009-04-12 17:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-12 16:47 [rfc 0/4] x86 - apic dummy ops with cleanups Cyrill Gorcunov
2009-04-12 16:47 ` [rfc 1/4] x86: irq.c - tiny cleanup Cyrill Gorcunov
2009-04-12 17:25 ` Ingo Molnar
2009-04-12 17:53 ` Cyrill Gorcunov [this message]
2009-04-12 17:57 ` [tip:x86/apic] " tip-bot for Cyrill Gorcunov
2009-04-12 16:47 ` [rfc 2/4] x86: apic - introduce imcr_ helpers Cyrill Gorcunov
2009-04-12 17:57 ` [tip:x86/apic] " tip-bot for Cyrill Gorcunov
2009-04-12 16:47 ` [rfc 3/4] x86: apic - introduce dummy apic operations Cyrill Gorcunov
2009-04-12 17:57 ` [tip:x86/apic] " tip-bot for Cyrill Gorcunov
2009-04-12 16:47 ` [rfc 4/4] x86: smp.c - align smp_ops assignments Cyrill Gorcunov
2009-04-12 17:58 ` [tip:x86/apic] " tip-bot for Cyrill Gorcunov
2009-04-12 17:24 ` [rfc 0/4] x86 - apic dummy ops with cleanups Ingo Molnar
2009-04-12 18:00 ` Cyrill Gorcunov
2009-04-12 18:02 ` Ingo Molnar
2009-04-12 18:12 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090412175304.GC6942@lenovo \
--to=gorcunov@gmail.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=xemul@openvz.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.