Re: [PATCH] General fix for Palm27x aSoC driver

[Marek Vasut <marek.vasut@gmail.com>]

On Sunday 12 of April 2009 19:06:26 Mark Brown wrote:
> On Sun, Apr 12, 2009 at 06:58:42PM +0200, Marek Vasut wrote:
> > +static struct platform_device palmld_pxa2xx_pcm = {
> > +	.name = "pxa2xx-pcm",
> > +	.id   = -1,
> > +};
>
> This should follow the pattern that everything else uses with the struct
> platform_device in devices.c and board files triggering registration of
> that.

Half of the platforms use static struct, half use struct. Probably someone 
should send a huge patch to make it consistent. I'd like to have it 
consistent at least inside the platform file.

>
> > +static struct platform_device palmld_pxa2xx_ac97 = {
> > +	.name = "pxa2xx-ac97",
> > +	.id   = -1,
> > +	.dev  = {
> > +		.platform_data = &palmld_ac97_pdata,
> > +	},
> > +};
>
> No, use pxa_set_ac97_info().

How?

>
> > +static struct platform_device palmld_wm9712_codec = {
>
> No, the WM9712 is not a platform device.