Re: [tip:x86/setup] x86, setup: "glove box" BIOS calls -- infrastructure

[Ingo Molnar <mingo@elte.hu>]

* Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Avi Kivity <avi@redhat.com> wrote:
> 
> > Ingo Molnar wrote:
> >>> Sure, go ahead and wrap them in some kind of "save and restore all  
> >>> registers" wrapping, but nothing fancier than that. It would just be 
> >>> overkill, and likely to break more than it fixes.
> >>>     
> >>
> >> Yeah. I only brought up the virtualization thing as a 
> >> hypothetical: "if" corrupting the main OS ever became a 
> >> widespread problem. Then i made the argument that this is 
> >> unlikely to happen, because Windows will be affected by it just 
> >> as much. (while register state corruptions might go unnoticed 
> >> much more easily, just via the random call-environment clobbering 
> >> of registers by Windows itself.)
> >>
> >> The only case where i could see virtualization to be useful is 
> >> the low memory RAM corruption pattern that some people have 
> >> observed.
> >
> > You could easily check that by checksumming pages (or actually 
> > copying them to high memory) before the call, and verifying after 
> > the call.
> 
> Yes, we could do memory checks, and ... hey, we already do that:
> 
>    bb577f9: x86: add periodic corruption check
>    5394f80: x86: check for and defend against BIOS memory corruption
> 
> ... and i seem to be the one who implemented it! ;-)

s/implemented/merged+fixed :-)

	Ingo