From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] fix grub-setup on kfreebsd by adding 0x10 to the sysctl ("kern.geom.debugflags") flags
Date: Mon, 13 Apr 2009 16:49:02 +0200 [thread overview]
Message-ID: <20090413144902.GB22165@thorin> (raw)
In-Reply-To: <1239632779.3747.32.camel@fz.local>
On Mon, Apr 13, 2009 at 04:26:19PM +0200, Felix Zielcke wrote:
> +#ifdef __FreeBSD_kernel__
Unfortunately FreeBSD doesn't define __FreeBSD_kernel__, so we need
to check for both macros.
> +#if defined __FreeBSD_kernel__
> + int sysctl_flags, sysctl_oldflags;
> + size_t sysctl_size = sizeof (sysctl_flags);
You can add a `const' on this one.
> + sysctl_flags = sysctl_oldflags |= 0x10;
Shouldn't this be "sysctl_oldflags | 0x10" ?
Btw you can avoid the two subsequent calls if sysctl_flags == sysctl_oldflags.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2009-04-13 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 13:32 [PATCH] fix grub-setup on kfreebsd by adding 0x10 to the sysctl ("kern.geom.debugflags") flags Felix Zielcke
2009-04-13 14:26 ` Felix Zielcke
2009-04-13 14:49 ` Robert Millan [this message]
2009-04-13 15:11 ` Felix Zielcke
2009-04-13 19:11 ` Robert Millan
2009-04-14 7:01 ` Felix Zielcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413144902.GB22165@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.