From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH v2] dm table: verify each table mapping is HW sector aligned Date: Mon, 13 Apr 2009 12:02:21 -0400 Message-ID: <20090413160221.GA4709@redhat.com> References: <1239335895-18613-1-git-send-email-snitzer@redhat.com> <20090410043106.GA18995@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20090410043106.GA18995@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: dm-devel@redhat.com List-Id: dm-devel.ids On Fri, Apr 10 2009 at 12:31am -0400, Mike Snitzer wrote: > On Thu, Apr 09 2009 at 11:58pm -0400, > Mike Snitzer wrote: > > > Each mapping in a DM table must be properly aligned on HW sector > > boundaries. This is particularly important when a DM table is composed > > of mappings for devices with different HW sector sizes. > > > > Signed-off-by: Mike Snitzer > > --- > > drivers/md/dm-table.c | 112 +++++++++++++++++++++++++++++++++++++++++++------ > > 1 files changed, 99 insertions(+), 13 deletions(-) > > This patch applies cleanly, but with fuzz, to the most recent linux-2.6 > (as of this writing: 62b8e680e). But I just noticed a flaw in the 'remaining_sectors' calculation (when the target's len is less than the overall table's H/W sector size). I'll be posting a new patch (v3) shortly. Mike