From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LtRNp-0007SW-GM for mharc-grub-devel@gnu.org; Mon, 13 Apr 2009 14:59:53 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LtRNn-0007S7-4R for grub-devel@gnu.org; Mon, 13 Apr 2009 14:59:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LtRNh-0007Rn-O0 for grub-devel@gnu.org; Mon, 13 Apr 2009 14:59:49 -0400 Received: from [199.232.76.173] (port=33027 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LtRNh-0007Rk-I8 for grub-devel@gnu.org; Mon, 13 Apr 2009 14:59:45 -0400 Received: from aybabtu.com ([69.60.117.155]:56205) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LtRNh-0002KK-5x for grub-devel@gnu.org; Mon, 13 Apr 2009 14:59:45 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LtRCE-0007Yv-Ll for grub-devel@gnu.org; Mon, 13 Apr 2009 20:47:55 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LtRNe-0006Gf-4e for grub-devel@gnu.org; Mon, 13 Apr 2009 20:59:42 +0200 Date: Mon, 13 Apr 2009 20:59:42 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090413185942.GA24072@thorin> References: <1239032043.8986.27.camel@mj> <20090413141657.GE12170@thorin> <1239635806.18804.8.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1239635806.18804.8.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Video mode fixes in linux loader X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2009 18:59:51 -0000 On Mon, Apr 13, 2009 at 11:16:46AM -0400, Pavel Roskin wrote: > On Mon, 2009-04-13 at 16:16 +0200, Robert Millan wrote: > > Please, in general, when you modify code that has been actively worked on > > by someone, try to get that person involved. > > I tried, but probably not hard enough. Sorry. No problem :-) > > Ok, BUT if we're already in vesa mode, and we know it works (since we're using > > it), there's no point in wasting time only to get a worse mode. > > Maybe we should introduce another macro, e.g. > GRUB_LINUX_VID_MODE_CURRENT, recognize it in the loader and default to > it. If we're going to get creative and add new options that weren't present in the legacy interface, then I'd really prefer if we design a new one, and better a kernel-independant one like an env variable (we discussed this in another thread, but didn't agree on which name to use yet). > Yes, failed loading of one kernel should not affect loading of another > kernel. That was the most annoying bug, and I hope it's fixed now. Yeah I don't see anything wrong with this situation now, but I could be missing something, since there are many ways to "fail". > > > Finally, "vga=ask" is now recognized. > > > > With the new loader, Linux' 16-bit entry code is no longer responsible for > > setting vesa modes, therefore vga=ask can't work. There's no point in > > recognizing it (except to warn the user). > > I agree. Generally, "vga=random_string" causes an error now. Perhaps > any unrecognized values of "vga" should cause a warning, not an error. Probably better when it comes to headless machines, yes... -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."