From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] sh7786: modify usb setup timeout judgment bug.
Date: Mon, 13 Apr 2009 22:10:11 +0000 [thread overview]
Message-ID: <20090413221011.GE14847@linux-sh.org> (raw)
In-Reply-To: <uskkdh0oz.wl%morimoto.kuninori@renesas.com>
On Fri, Apr 10, 2009 at 09:54:07AM +0900, Kuninori Morimoto wrote:
> Timeout counter "i" can reach -1 if USB setup isn't done.
> And "i" can be 0 if USB setup is done when last possible moment.
> Then it is judged to fail though setup is done.
> This patch modify this problem.
> Special thanks to Mr. Juha Leppanen and Iwamatsu-san for nice advice.
>
> Reported-by: "Juha Leppanen" <juha_motorsportcom@luukku.com>
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
> >> Paul
> Can you test this patch on Urquell board please ?
>
Ok, back in the office now. Yes, this works fine. I'll add a Reviewed-by
for Iwamatsu-san.
> >> Michael
> I will try to create patch which skip setup if bootloader is already done.
> please wait.
>
Since this current patches addresses a bug, I'll check this in as it is.
If you want to post an incremental patch implementing Michael's
suggestion on top of this, we can roll that in to a later update.
You might want to make sure you aren't stepping on anything Shimoda-san
is doing though with his fix aimed at the host controller drivers.
prev parent reply other threads:[~2009-04-13 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 0:54 [PATCH v2] sh7786: modify usb setup timeout judgment bug Kuninori Morimoto
2009-04-13 22:10 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413221011.GE14847@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.