From: Akinobu Mita <akinobu.mita@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ext2: fix missing mutex_unlock in error path
Date: Tue, 14 Apr 2009 16:36:31 +0900 [thread overview]
Message-ID: <20090414073631.GA4145@localhost.localdomain> (raw)
Add missing mutex_unlock in error path in ext2_quota_write()
Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index f983225..5c4afe6 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1395,8 +1395,10 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
blk++;
}
out:
- if (len == towrite)
+ if (len == towrite) {
+ mutex_unlock(&inode->i_mutex);
return err;
+ }
if (inode->i_size < off+len-towrite)
i_size_write(inode, off+len-towrite);
inode->i_version++;
next reply other threads:[~2009-04-14 7:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 7:36 Akinobu Mita [this message]
2009-04-14 7:43 ` [PATCH] ext2: fix missing mutex_unlock in error path Manish Katiyar
2009-04-14 7:43 ` Manish Katiyar
2009-04-14 7:43 ` Jan Kara
2009-04-14 9:35 ` Akinobu Mita
2009-04-14 9:43 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090414073631.GA4145@localhost.localdomain \
--to=akinobu.mita@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.