All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muli Ben-Yehuda <muli@il.ibm.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, alexisb@us.ibm.com
Subject: Re: [PATCH] calgary: remove IOMMU_DEBUG
Date: Tue, 14 Apr 2009 13:26:45 +0300	[thread overview]
Message-ID: <20090414102645.GD13863@il.ibm.com> (raw)
In-Reply-To: <20090414120827G.fujita.tomonori@lab.ntt.co.jp>

On Tue, Apr 14, 2009 at 12:12:29PM +0900, FUJITA Tomonori wrote:
> CONFIG_IOMMU_DEBUG has depends on CONFIG_GART_IOMMU:
> 
> config IOMMU_DEBUG
> 	bool "Enable IOMMU debugging"
> 	depends on GART_IOMMU && DEBUG_KERNEL
> 	depends on X86_64
> 
> So it's not useful to have CONFIG_IOMMU_DEBUG in Calgary IOMMU code,
> which does the extra checking of the bitmap space management.
> 
> And Calgary uses the iommu helper for the bitmap space management now
> so it would be better to have the extra checking feature in the iommu
> helper rather than Calgary code (if necessary).
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>

Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>

Cheers,
Muli
-- 
Muli Ben-Yehuda | muli@il.ibm.com | +972-4-8281080
Manager, Virtualization and Systems Architecture
Master Inventor, IBM Haifa Research Laboratory

SYSTOR 2009---The Israeli Experimental Systems Conference
http://www.haifa.il.ibm.com/conferences/systor2009/

  reply	other threads:[~2009-04-14 10:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14  3:12 [PATCH] calgary: remove IOMMU_DEBUG FUJITA Tomonori
2009-04-14 10:26 ` Muli Ben-Yehuda [this message]
2009-04-14 11:06 ` [tip:core/iommu] x86: " tip-bot for FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090414102645.GD13863@il.ibm.com \
    --to=muli@il.ibm.com \
    --cc=alexisb@us.ibm.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.