All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>, linux-crypto@vger.kernel.org
Subject: Re: [RFC] [PATCH 2/4] cpu_chainiv: add percpu IV chain genarator
Date: Tue, 14 Apr 2009 15:05:35 +0200	[thread overview]
Message-ID: <20090414130535.GM6791@secunet.com> (raw)
In-Reply-To: <20090409032045.GA2232@gondor.apana.org.au>

On Thu, Apr 09, 2009 at 11:20:45AM +0800, Herbert Xu wrote:
> 
> You can allocate eseqiv(alg), e.g., eseqiv(cbc(aes)).
> 

Ok, that's possible. I missed this possibility, probaply because nobody
is actually doing it this way. Thanks!

Unfortunately eseqiv does not work out of the box if we do synchronous
encryption. 

If crypto_ablkcipher_encrypt() returns synchronous, eseqiv_complete2()
is called even if req->giv is already the pointer to the generated IV.
The generated IV is overwritten with some random data in this case.

I fixed this by calling eseqiv_complete2() just in the case when an
asynchronous algorithm would call eseqiv_complete() as the complete
function. I'll send the patch with an extra mail.

Now pcrypt runs fine together with eseqiv and the throughput
results are very similar to the ones with cpu_chainiv.

Steffen

  reply	other threads:[~2009-04-14 13:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-16 11:49 [RFC] [PATCH 0/4] Parallel IPsec Steffen Klassert
2009-03-16 11:51 ` [RFC] [PATCH 1/4] padata: generic interface for parallel processing Steffen Klassert
2009-03-16 11:52 ` [RFC] [PATCH 2/4] cpu_chainiv: add percpu IV chain genarator Steffen Klassert
2009-03-27  8:36   ` Herbert Xu
2009-03-30 11:54     ` Steffen Klassert
2009-03-30 13:19       ` Herbert Xu
2009-03-30 14:49         ` Steffen Klassert
2009-04-08 11:40         ` Steffen Klassert
2009-04-09  3:20           ` Herbert Xu
2009-04-14 13:05             ` Steffen Klassert [this message]
2009-03-16 11:54 ` [RFC] [PATCH 3/4] pcrypt: Add pcrypt crypto parallelization engine Steffen Klassert
2009-03-16 11:55 ` [RFC] [PATCH 4/4] esp: add the pcrypt hooks to esp Steffen Klassert
2009-03-27  8:44   ` Herbert Xu
2009-03-30 12:22     ` Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090414130535.GM6791@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.