From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mo-p05-ob.rzone.de ([81.169.146.181]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1Lthy4-0007aV-23 for linux-mtd@lists.infradead.org; Tue, 14 Apr 2009 12:42:30 +0000 From: Stefan Roese To: Grant Likely Subject: Re: [PATCH 1/4 v2] mtd: physmap_of: Add multiple regions and concatenation support Date: Tue, 14 Apr 2009 14:42:19 +0200 References: <1239093559-12043-1-git-send-email-sr@denx.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904141442.19456.sr@denx.de> Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org, linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sunday 12 April 2009, Grant Likely wrote: > On Tue, Apr 7, 2009 at 2:39 AM, Stefan Roese wrote: > > This patch adds support to handle multiple non-identical chips in one > > flash device tree node. It also adds concat support to physmap_of. This > > makes it possible to support e.g. the Intel P30 48F4400 chips which > > internally consists of 2 non-identical NOR chips on one die. Additionally > > partitions now can span over multiple chips. > > [...] > > > Signed-off-by: Stefan Roese > > CC: Grant Likely > > Looks good to me. To comments below, but neither are enough to hold back > my: > > Reviewd-by: Grant Likely Thanks. > However, I have not tested this. I'd like to hear of some larger > field testing before it is merged. OK, I'll address your latest comments and resend a (hopefully) last version of this patchset. Thanks. Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Subject: Re: [PATCH 1/4 v2] mtd: physmap_of: Add multiple regions and concatenation support Date: Tue, 14 Apr 2009 14:42:19 +0200 Message-ID: <200904141442.19456.sr@denx.de> References: <1239093559-12043-1-git-send-email-sr@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: Grant Likely Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Sunday 12 April 2009, Grant Likely wrote: > On Tue, Apr 7, 2009 at 2:39 AM, Stefan Roese wrote: > > This patch adds support to handle multiple non-identical chips in one > > flash device tree node. It also adds concat support to physmap_of. This > > makes it possible to support e.g. the Intel P30 48F4400 chips which > > internally consists of 2 non-identical NOR chips on one die. Additionally > > partitions now can span over multiple chips. > > [...] > > > Signed-off-by: Stefan Roese > > CC: Grant Likely > > Looks good to me. To comments below, but neither are enough to hold back > my: > > Reviewd-by: Grant Likely Thanks. > However, I have not tested this. I'd like to hear of some larger > field testing before it is merged. OK, I'll address your latest comments and resend a (hopefully) last version of this patchset. Thanks. Stefan