diff for duplicates of <200904141457.06664.sr@denx.de> diff --git a/a/1.txt b/N1/1.txt index 657e7e4..fd3c817 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,18 +1,22 @@ On Sunday 12 April 2009, Grant Likely wrote: -> > + info = kzalloc(sizeof(struct of_flash) + -> > + sizeof(struct of_flash_list) * count, GFP_KERNEL); -> > + if (!info) -> > + goto err_out; +> > + =A0 =A0 =A0 info =3D kzalloc(sizeof(struct of_flash) + +> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sizeof(struct of_flash_lis= +t) * count, GFP_KERNEL); +> > + =A0 =A0 =A0 if (!info) +> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto err_out; > > + -> > + mtd_list = kzalloc(sizeof(struct mtd_info) * count, GFP_KERNEL); +> > + =A0 =A0 =A0 mtd_list =3D kzalloc(sizeof(struct mtd_info) * count, GFP= +_KERNEL); > > Typically I prefer to see a single kzalloc in a driver which allocates > all the space needed in one go because it simplifies the error/unwind > path. -In general ack, but it doesn't make much sense in this case. The 2nd malloc is -for an temporary buffer needed for mtd_concat_create() call (list of struct -mtd_info. I can't really combine those two areas. So I'll leave this +In general ack, but it doesn't make much sense in this case. The 2nd malloc= + is=20 +for an temporary buffer needed for mtd_concat_create() call (list of struct= +=20 +mtd_info. I can't really combine those two areas. So I'll leave this=20 untouched. Best regards, diff --git a/a/content_digest b/N1/content_digest index 13a6948..0ea79f1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,29 +4,32 @@ "Subject\0Re: [PATCH 1/4 v2] mtd: physmap_of: Add multiple regions and concatenation support\0" "Date\0Tue, 14 Apr 2009 14:57:06 +0200\0" "To\0devicetree-discuss@ozlabs.org\0" - "Cc\0Grant Likely <grant.likely@secretlab.ca>" - linuxppc-dev@ozlabs.org + "Cc\0linuxppc-dev@ozlabs.org" " linux-mtd@lists.infradead.org\0" "\00:1\0" "b\0" "On Sunday 12 April 2009, Grant Likely wrote:\n" - "> > + \302\240 \302\240 \302\240 info = kzalloc(sizeof(struct of_flash) +\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240sizeof(struct of_flash_list) * count, GFP_KERNEL);\n" - "> > + \302\240 \302\240 \302\240 if (!info)\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 goto err_out;\n" + "> > + =A0 =A0 =A0 info =3D kzalloc(sizeof(struct of_flash) +\n" + "> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sizeof(struct of_flash_lis=\n" + "t) * count, GFP_KERNEL);\n" + "> > + =A0 =A0 =A0 if (!info)\n" + "> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto err_out;\n" "> > +\n" - "> > + \302\240 \302\240 \302\240 mtd_list = kzalloc(sizeof(struct mtd_info) * count, GFP_KERNEL);\n" + "> > + =A0 =A0 =A0 mtd_list =3D kzalloc(sizeof(struct mtd_info) * count, GFP=\n" + "_KERNEL);\n" ">\n" "> Typically I prefer to see a single kzalloc in a driver which allocates\n" "> all the space needed in one go because it simplifies the error/unwind\n" "> path.\n" "\n" - "In general ack, but it doesn't make much sense in this case. The 2nd malloc is \n" - "for an temporary buffer needed for mtd_concat_create() call (list of struct \n" - "mtd_info. I can't really combine those two areas. So I'll leave this \n" + "In general ack, but it doesn't make much sense in this case. The 2nd malloc=\n" + " is=20\n" + "for an temporary buffer needed for mtd_concat_create() call (list of struct=\n" + "=20\n" + "mtd_info. I can't really combine those two areas. So I'll leave this=20\n" "untouched.\n" "\n" "Best regards,\n" Stefan -e25bb321c09626e05a21ecf40af61e350d9da8a9c8bf5d3805902150c2605a98 +7f3de26bec741e7586e2ef59dbf0531f7d3d79028fbf5650f9eee7ec19ae8582
diff --git a/a/content_digest b/N2/content_digest index 13a6948..fbb6d22 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,12 +1,12 @@ "ref\01239093559-12043-1-git-send-email-sr@denx.de\0" "ref\0fa686aa40904112258n1cc23b48t80b135b7016e9760@mail.gmail.com\0" - "From\0Stefan Roese <sr@denx.de>\0" + "ref\0fa686aa40904112258n1cc23b48t80b135b7016e9760-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org\0" + "From\0Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>\0" "Subject\0Re: [PATCH 1/4 v2] mtd: physmap_of: Add multiple regions and concatenation support\0" "Date\0Tue, 14 Apr 2009 14:57:06 +0200\0" - "To\0devicetree-discuss@ozlabs.org\0" - "Cc\0Grant Likely <grant.likely@secretlab.ca>" - linuxppc-dev@ozlabs.org - " linux-mtd@lists.infradead.org\0" + "To\0devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org\0" + "Cc\0linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org" + " linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org\0" "\00:1\0" "b\0" "On Sunday 12 April 2009, Grant Likely wrote:\n" @@ -29,4 +29,4 @@ "Best regards,\n" Stefan -e25bb321c09626e05a21ecf40af61e350d9da8a9c8bf5d3805902150c2605a98 +972429701b0417adcc4ea2f8e03c3ffeaef870e317a5fe00c1ab37bcdbd1b43e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.