Re: [STABLE][PATCH] gdbm: use LDFLAGS (fixes QA error)

From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Cc: Koen Kooi <koen@openembedded.org>
Subject: Re: [STABLE][PATCH] gdbm: use LDFLAGS (fixes QA error)
Date: Tue, 14 Apr 2009 17:42:43 -0400	[thread overview]
Message-ID: <20090414214243.GF28306@denix.org> (raw)
In-Reply-To: <1239694534-23578-1-git-send-email-k.kooi@student.utwente.nl>

On Tue, Apr 14, 2009 at 09:35:34AM +0200, Koen Kooi wrote:
> From: Koen Kooi <koen@openembedded.org>

Is it a proper use of TARGET_CC_ARCH? As name suggests, it wasn't meant to 
deliver LDFLAGS to CC, only to specify the architecture. But as I can see, 
many recipes reuse this variable to stick additional flags for CC... So, I 
guess it's a common practice.

Acked-by: Denys Dmytriyenko <denis@denix.org>

> Signed-off-by: Koen Kooi <koen@openembedded.org>
> ---
>  recipes/gdbm/gdbm_1.8.3.bb |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/recipes/gdbm/gdbm_1.8.3.bb b/recipes/gdbm/gdbm_1.8.3.bb
> index f3beb47..883022e 100644
> --- a/recipes/gdbm/gdbm_1.8.3.bb
> +++ b/recipes/gdbm/gdbm_1.8.3.bb
> @@ -4,7 +4,7 @@ SECTION = "libs"
>  PRIORITY = "optional"
>  LICENSE = "GPL"
>  
> -PR = "r2"
> +PR = "r3"
>  
>  SRC_URI = "${GNU_MIRROR}/gdbm/gdbm-${PV}.tar.gz \
>  	   file://makefile.patch;patch=1 \
> @@ -12,6 +12,8 @@ SRC_URI = "${GNU_MIRROR}/gdbm/gdbm-${PV}.tar.gz \
>  
>  inherit autotools
>  
> +TARGET_CC_ARCH += "${LDFLAGS}"
> +
>  do_stage () {
>  	oe_libinstall -so -a libgdbm ${STAGING_LIBDIR}
>  	install -m 0644 ${S}/gdbm.h ${STAGING_INCDIR}/
> -- 
> 1.5.6.5
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel