All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: tiobench read 50% regression with 2.6.30-rc1
Date: Wed, 15 Apr 2009 13:30:31 +0200	[thread overview]
Message-ID: <20090415113031.GY5178@kernel.dk> (raw)
In-Reply-To: <x49ws9mgnv0.fsf@segfault.boston.devel.redhat.com>

On Wed, Apr 15 2009, Jeff Moyer wrote:
> Jens Axboe <jens.axboe@oracle.com> writes:
> 
> > On Wed, Apr 15 2009, Jeff Moyer wrote:
> >> I tested this using iozone to read a file from an NFS client.  The
> >> iozone command line was:
> >>   iozone -s 2000000 -r 64 -f /mnt/test/testfile -i 1 -w
> >> 
> >> The numbers in the nfsd's row represent the number of nfsd threads.  I
> >> included numbers for the deadline scheduler as well for comparison.
> >> 
> >>                v2.6.29
> >> 
> >> nfsd's  |   1    |  2   |   4   |   8
> >> --------+---------------+-------+------
> >> cfq     | 91356 | 66391 | 61942 | 51674
> >> deadline| 43207 | 67436 | 96289 | 107784
> >> 
> >>               2.6.30-rc1
> >> 
> >> nfsd's  |   1   |   2   |   4   |   8
> >> --------+---------------+-------+------
> >> cfq     | 43127 | 22354 | 20858 | 21179
> >> deadline| 43732 | 68059 | 76659 | 83231
> >> 
> >>           2.6.30-rc1 + cfq fix
> >> 
> >> nfsd's  |   1    |    2   |   4   |   8
> >> --------+-----------------+-------+------
> >> cfq     | 114602 | 102280 | 43479 | 43160
> >> 
> >> As you can see, for 1 and 2 threads, the patch *really* helps out.  We
> >> still don't get back the performance for 4 and 8 nfsd threads, though.
> >> It's interesting to note that the deadline scheduler regresses for 4 and
> >> 8 threads, as well.  I think we've still got some digging to do.
> >
> > Wow, that does indeed look pretty good!
> 
> Please don't lose the later part of the message, which is that both CFQ
> and deadline regress for 4 and 8 threads when moving from 2.6.29 to
> 2.6.30-rc1!  There have been way too many changes to keep track of in
> this area recently, and I'd like to get some confidence that we
> understand the performance implications of them.

I'm definitely not, in fact pending patches should make it better! For
the nfs case, I'm still a big proponent of explicitly getting the io
context sharing in place, instead of adding code at the other end to
try and fix things up.

> >> I'll try the cfq close cooperator patches next.
> >
> > I have a pending update on the coop patch that isn't pushed out yet, I
> > hope to have it finalized and tested later today. Hopefully, with that,
> > we should be able to maintain > 100Mb/sec for 4 and 8 threads.
> 
> OK, please let me know when and where this is available and I'll give it
> a try.

I sent you email about ~10 minutes ago or so about that very patch.

-- 
Jens Axboe


  reply	other threads:[~2009-04-15 11:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-09  8:29 tiobench read 50% regression with 2.6.30-rc1 Zhang, Yanmin
2009-04-09  9:57 ` Jens Axboe
2009-04-10  2:29   ` Zhang, Yanmin
2009-04-10  7:26     ` Jens Axboe
2009-04-14 12:14     ` Jens Axboe
2009-04-15  1:27       ` Zhang, Yanmin
2009-04-15  6:27         ` Jens Axboe
2009-04-15  4:07       ` Jeff Moyer
2009-04-15  6:26         ` Jens Axboe
2009-04-15 11:25           ` Jeff Moyer
2009-04-15 11:30             ` Jens Axboe [this message]
2009-04-15 12:00               ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090415113031.GY5178@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.