diff for duplicates of <20090415114154.GI9809@random.random> diff --git a/a/1.txt b/N1/1.txt index 442f21f..d704c65 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -31,3 +31,9 @@ mmu_notifier_invalidate_page. All that is important is to run mmu_notifier_invalidate_page _after_ the ptep_clear_young_notify, so that we don't nuke secondary mappings on the pages unless we really go to nuke the pte. + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index b2e8708..92d1d06 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -49,6 +49,12 @@ "mmu_notifier_invalidate_page. All that is important is to run\n" "mmu_notifier_invalidate_page _after_ the ptep_clear_young_notify, so\n" "that we don't nuke secondary mappings on the pages unless we really go\n" - to nuke the pte. + "to nuke the pte.\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -9b7094f1abfc6ce715c5bface5b1686ed4b67ff1481a34ad02d221c03afc18fb +714a2782bcccde3bdf5cb3962d43032b255a6555948ab1cb7d481432e35a2080
diff --git a/a/1.txt b/N2/1.txt index 442f21f..c299b32 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,15 +1,15 @@ On Wed, Apr 15, 2009 at 08:39:04PM +0900, KOSAKI Motohiro wrote: -> >> + if (!migration) { -> >> + /* re-check */ -> >> + if (PageSwapCache(page) && -> >> + page_count(page) != page_mapcount(page) + 2) { -> >> + /* We lose race against get_user_pages_fast() */ -> >> + set_pte_at(mm, address, pte, pteval); -> >> + ret = SWAP_FAIL; -> >> + goto out_unmap; -> >> + } -> >> + } -> >> + mmu_notifier_invalidate_page(vma->vm_mm, address); +> >> + if (!migration) { +> >> + /* re-check */ +> >> + if (PageSwapCache(page) && +> >> + page_count(page) != page_mapcount(page) + 2) { +> >> + /* We lose race against get_user_pages_fast() */ +> >> + set_pte_at(mm, address, pte, pteval); +> >> + ret = SWAP_FAIL; +> >> + goto out_unmap; +> >> + } +> >> + } +> >> + mmu_notifier_invalidate_page(vma->vm_mm, address); > > > > With regard to mmu notifier, this is the opposite of the right > > ordering. One mmu_notifier_invalidate_page must run _before_ the first @@ -31,3 +31,9 @@ mmu_notifier_invalidate_page. All that is important is to run mmu_notifier_invalidate_page _after_ the ptep_clear_young_notify, so that we don't nuke secondary mappings on the pages unless we really go to nuke the pte. + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N2/content_digest index b2e8708..0d9988e 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -18,17 +18,17 @@ "\00:1\0" "b\0" "On Wed, Apr 15, 2009 at 08:39:04PM +0900, KOSAKI Motohiro wrote:\n" - "> >> + \302\240 \302\240 if (!migration) {\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 /* re-check */\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 if (PageSwapCache(page) &&\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 page_count(page) != page_mapcount(page) + 2) {\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 /* We lose race against get_user_pages_fast() */\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 set_pte_at(mm, address, pte, pteval);\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 ret = SWAP_FAIL;\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 goto out_unmap;\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 }\n" - "> >> + \302\240 \302\240 }\n" - "> >> + \302\240 \302\240 mmu_notifier_invalidate_page(vma->vm_mm, address);\n" + "> >> + if (!migration) {\n" + "> >> + /* re-check */\n" + "> >> + if (PageSwapCache(page) &&\n" + "> >> + page_count(page) != page_mapcount(page) + 2) {\n" + "> >> + /* We lose race against get_user_pages_fast() */\n" + "> >> + set_pte_at(mm, address, pte, pteval);\n" + "> >> + ret = SWAP_FAIL;\n" + "> >> + goto out_unmap;\n" + "> >> + }\n" + "> >> + }\n" + "> >> + mmu_notifier_invalidate_page(vma->vm_mm, address);\n" "> >\n" "> > With regard to mmu notifier, this is the opposite of the right\n" "> > ordering. One mmu_notifier_invalidate_page must run _before_ the first\n" @@ -49,6 +49,12 @@ "mmu_notifier_invalidate_page. All that is important is to run\n" "mmu_notifier_invalidate_page _after_ the ptep_clear_young_notify, so\n" "that we don't nuke secondary mappings on the pages unless we really go\n" - to nuke the pte. + "to nuke the pte.\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -9b7094f1abfc6ce715c5bface5b1686ed4b67ff1481a34ad02d221c03afc18fb +76c439f703ccb9b89b432caf09ba7dd1f2dc132b9c697c1d3558e573c8d0fc18
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.