Re: [PATCH 3/6] Add USB support for SH7724

[Paul Mundt <lethal@linux-sh.org>]

On Wed, Apr 15, 2009 at 09:16:10PM +0900, Magnus Damm wrote:
> On Wed, Apr 15, 2009 at 8:49 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > On Wed, Apr 15, 2009 at 11:42 AM, Kuninori Morimoto
> > <morimoto.kuninori@renesas.com> wrote:
> >> +++ b/arch/sh/kernel/cpu/sh4a/setup-sh7724.c
> 
> >> +#define UPONCR0 ? ? ? ? ? ? ? ?0xa40501d4
> >> +#define UPONCR1 ? ? ? ? ? ? ? ?0xa4050192
> >> +#define USBPOWERON ? ? 0x0600
> >> +static void __init sh7724_usb_setup(void)
> >> +{
> >> + ? ? ? /*
> >> + ? ? ? ?* USB initial settings
> >> + ? ? ? ?*
> >> + ? ? ? ?* The following settings are necessary
> >> + ? ? ? ?* for using the USB modules.
> >> + ? ? ? ?*
> >> + ? ? ? ?* see "USB Inital Settings" for detail
> >> + ? ? ? ?*/
> >> + ? ? ? __raw_writew(USBPOWERON , UPONCR0);
> >> + ? ? ? __raw_writew(USBPOWERON , UPONCR1);
> >> +}
> >
> > Hm... In the future we want to control the above dynamically for
> > better power savings. I guess it's ok as-is for now.
> 
> Looking a bit in r8a66597.h, I wonder if USBPOWERON is similar to
> VBOUT that is present in DVSTCR on external devices?
> 
Also note that the same issue exists on SH7786, so if this is fixed a bit
more intelligently, the same thing should carry over there.