All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Gary Hade <garyhade@us.ibm.com>,
	lcm@us.ibm.com, "Pallipadi,
	Venkatesh" <venkatesh.pallipadi@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] irq: make set_affinity to return status
Date: Wed, 15 Apr 2009 12:57:44 +0930	[thread overview]
Message-ID: <200904151257.44715.rusty@rustcorp.com.au> (raw)
In-Reply-To: <49E4F54C.7030807@kernel.org>

On Wed, 15 Apr 2009 06:12:52 am Yinghai Lu wrote:
> 
> Impact: prepare to use it to keep affinity consistent
> 
> according to Ingo, change set_affinity() in irq_chip to return int.

I prefer a bool, or an actual -errno rather than -1.  Maybe Ingo feels
differently?

Plus:

> @@ -199,6 +199,8 @@ static void octeon_irq_ciu0_set_affinity
>  	 */
>  	cvmx_read_csr(CVMX_CIU_INTX_EN0(cvmx_get_core_num() * 2));
>  	write_unlock(&octeon_irq_ciu0_rwlock);
> +
> +	reutrn 0;
>  }

Typo.

Thanks,
Rusty.

  reply	other threads:[~2009-04-15  3:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200903231757.53709.rusty@rustcorp.com.au>
     [not found] ` <20090323165921.GA7559@us.ibm.com>
     [not found]   ` <200903241553.58209.rusty@rustcorp.com.au>
     [not found]     ` <20090402013108.GB7103@us.ibm.com>
     [not found]       ` <20090404003520.GA8847@us.ibm.com>
     [not found]         ` <20090410215515.GC7242@us.ibm.com>
     [not found]           ` <20090411065510.GA11799@elte.hu>
     [not found]             ` <20090413220321.GA11098@us.ibm.com>
     [not found]               ` <49E4146C.7060507@kernel.org>
     [not found]                 ` <49E4162A.3060701@kernel.org>
     [not found]                   ` <20090414131711.GA4403@elte.hu>
2009-04-14 20:41                     ` [PATCH 1/4] irq: correct CPUMASKS_OFFSTACK typo -v2 Yinghai Lu
2009-04-14 20:42                       ` [PATCH 2/4] irq: make set_affinity to return status Yinghai Lu
2009-04-15  3:27                         ` Rusty Russell [this message]
2009-04-15  5:44                         ` [PATCH 2/4] irq: make set_affinity to return status -v2 Yinghai Lu
2009-04-14 20:43                       ` [PATCH 3/4] irq: only update affinity in chip set_affinity() -v3 Yinghai Lu
2009-04-14 20:44                       ` [PATCH 4/4] irq: move move_irq_desc calling to set_affinity directly -v4 Yinghai Lu
2009-04-14 22:03                         ` Suresh Siddha
2009-04-14 20:59                       ` [PATCH 1/4] irq: correct CPUMASKS_OFFSTACK typo -v2 Andrew Morton
2009-04-15 10:01                         ` Ingo Molnar
2009-04-15 19:17                           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904151257.44715.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=garyhade@us.ibm.com \
    --cc=hpa@zytor.com \
    --cc=lcm@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@intel.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.